test: add check for keyframe selector to #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
approved these changes
Sep 22, 2023
SethFalco
force-pushed
the
test-keyframe-selector
branch
from
d8e5bb4
to
fac6daa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test for issue reported regarding keyframe selectors.
This issue was caused by an upstream bug in csstree, which CSSO resolved on their end.
I can confirm that with svgo v3.0.2 the issue on longer occurs. However, I think it's worth including a unit test for this before closing the issue.
Uses a simplified version of my original SVG for the test. This is primarily to ensure it does not remove the
tokeyword, which was the original bug.Related