fix(inlineStyles): refactor how styles are collected #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nono
referenced
this pull request
in cozy/cozy-stack
Dec 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [svgo](https://svgo.dev) ([source](https://togithub.com/svg/svgo)) | [`3.0.5` -> `3.1.0`](https://renovatebot.com/diffs/npm/svgo/3.0.5/3.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>svg/svgo (svgo)</summary> ### [`v3.1.0`](https://togithub.com/svg/svgo/releases/tag/v3.1.0) [Compare Source](https://togithub.com/svg/svgo/compare/v3.0.5...v3.1.0) #### What's Changed ##### Bug Fixes - [**Prefix IDs**](https://svgo.dev/docs/plugins/prefix-ids/), correctly prefix IDs when `<style>` tag contains XML comments. By [@​john-neptune](https://togithub.com/john-neptune) in [https://github.com/svg/svgo/pull/1736](https://togithub.com/svg/svgo/pull/1736) - [**Remove Hidden Elements**](https://svgo.dev/docs/plugins/remove-hidden-elems/), improve handling of definitions (`<defs>`), namely when `<defs>` are defined at the end of the document. By [@​KTibow](https://togithub.com/KTibow) in [https://github.com/svg/svgo/pull/1879](https://togithub.com/svg/svgo/pull/1879) - [**Cleanup Enable Background**](https://svgo.dev/docs/plugins/cleanup-enable-background/), clean up inline-styles too. By [@​SethFalco](https://togithub.com/SethFalco) in [https://github.com/svg/svgo/pull/1866](https://togithub.com/svg/svgo/pull/1866) - [**Cleanup IDs**](https://svgo.dev/docs/plugins/cleanup-ids/), handle URI encoded references properly. By [@​SethFalco](https://togithub.com/SethFalco) in [https://github.com/svg/svgo/pull/1880](https://togithub.com/svg/svgo/pull/1880) - [**Inline Styles**](https://svgo.dev/docs/plugins/inline-styles/), no longer crashes on non-inlined selectors with a pseudo-class. By [@​SethFalco](https://togithub.com/SethFalco) in [https://github.com/svg/svgo/pull/1865](https://togithub.com/svg/svgo/pull/1865) - Improve handling of URL references in reference attributes (`url('#a')`) across various plugins. By [@​SethFalco](https://togithub.com/SethFalco) in [https://github.com/svg/svgo/pull/1881](https://togithub.com/svg/svgo/pull/1881) ##### SVG Optimization - [**Remove Unknowns and Defaults**](https://svgo.dev/docs/plugins/remove-unknowns-and-defaults/), now removes defaults in XML declarations too, enabled by default and can be toggled with `defaultMarkupDeclarations`. By [@​SethFalco](https://togithub.com/SethFalco) in [https://github.com/svg/svgo/pull/1872](https://togithub.com/svg/svgo/pull/1872) #### Metrics Before and after using vectors from various sources, with the default preset of each respective version: | SVG | Original | v3.0.5 | v3.1.0 | Delta | |---|---|---|---|---| | [Arch Linux Logo](https://archlinux.org/art/) | 9.529 KiB | 4.608 KiB | 4.162 KiB | ⬇️ 0.446 KiB | | [Blobs](https://gitlab.gnome.org/GNOME/gnome-backgrounds/-/blob/main/backgrounds/blobs-d.svg) | 50.45 KiB | 42.949 KiB | 42.949 KiB | | | [Isometric Madness](https://inkscape.org/~Denis_Kuznetsky/%E2%98%85isometric-madness) | 869.034 KiB | 550.153 KiB | 550.153 KiB | | | [tldr-pages Banner](https://togithub.com/tldr-pages/tldr/blob/main/images/banner.svg) | 2.071 KiB | 1.07 KiB | 1.07 KiB | | | [Wikipedia Logo](https://en.wikipedia.org/wiki/File:Wikipedia-logo-v2.svg) | 161.551 KiB | 117.146 KiB | 116 KiB | ⬇️ 1.146 KiB | Before and after of the browser bundle of each respective version: | | v3.0.5 | v3.1.0 | Delta | |---|---|---|---| | svgo.browser.js | 657.5 kB | 660.9 kB | ⬆️ 3.4 kB | </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cozy/cozy-stack). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way selectors were collected before was problematic because it collected nested selectors too. Instead, we should collect all the Rules, then iterate through the SelectorLists. This solves the issue because we were accidentally collecting selectors nested under pseudo-classes and trying to apply them.
This also resolves a comment that was left in the implementation. For pseudo-classes that we can evaluate during optimization are no longer configurable via the
usePseudosparameter, we will determine which to keep ourselves.Related
not([attribute-name])is present in thestyle#1859