Fixes for svgo's stdout mode in 1.0.x #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `stdout` output mode (e.g. using `svgo -` within a pipeline), the time and optimization statistics shouldn't be printed in the output stream.
Not only does `console.log()` already print a newline after its output, but it prints a space between each of its arguments, so including `'\n'` as a second argument results in a trailing space, then a newline, then another newline. Excluding this extra `'\n'` results in just one newline after the data.
|
Nice catch! |
|
v1.0.3 with this fix has been just released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0.x seems to have introduced some extra junk in the output if you use
svgoinstdoutmode (i.e.-o -). Using the "with STDIN / STDOUT" usage documented in the README as an example:Obviously that extra stuff doesn't belong in
test.min.svg.This worked correctly in v0.7.x, I believe because the codepaths were more separated and process.stdout.write() was used instead of console.log().
Two proposed changes here:
printTimeInfo()/printProfitInfo()unlessoutput != '-'console.log()already prints a trailing newline and it prints spaces between its arguments, soconsole.log(data, '\n')means<data><space><newline><newline>; we probably just wantconsole.log(data)instead so we get<data><newline>Thank you for this wonderful project!