Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos #1179

Merged
merged 29 commits into from
Dec 17, 2020
Merged

typos #1179

merged 29 commits into from
Dec 17, 2020

Conversation

ordago
Copy link
Contributor

@ordago ordago commented Dec 17, 2020

All the changes are in either comments or test messages.

@ordago ordago mentioned this pull request Dec 17, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.889% when pulling 7ca6777 on ordago:1178-typos into c01bead on svgdotjs:master.

@Fuzzyma
Copy link
Member

Fuzzyma commented Dec 17, 2020

Oh wow! Did you use software or did you really do this one by one? :D

@Fuzzyma Fuzzyma merged commit 4f4dc2a into svgdotjs:master Dec 17, 2020
@ordago
Copy link
Contributor Author

ordago commented Dec 17, 2020

Hi @Fuzzyma
I used Phpstorm, and then went over the results manually since the names of variables, constants... give a lot of false positives.

I also saw these but didn't touch it because it was in code:

const image = canvas.image('spec/fictures/pixel.png')

const image = canvas.image('spec/fictures/pixel.png')

These should be fixtures instead of fictures, right?

@Fuzzyma
Copy link
Member

Fuzzyma commented Jan 14, 2021

@ordago wow, thanks! Yes, it should be fixtures. For the test, it doesn't really matter but ofc it would be better to be correct rather then wrong :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants