broker.py is not waiting for all threads to be finished

[crane-denny]

I did not dig now very deep into it.

If I run a script which adds and removes some IPs form an interface the scripts ends before all threads are done yet.
Would be nice if loop.py would catch this and block until all threads are finished.

Exception in thread Thread-1 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
File "/usr/lib/python2.7/threading.py", line 552, in __bootstrap_inner
File "/usr/local/lib/python2.7/dist-packages/pyroute2/iocore/broker.py", line 152, in run
File "/usr/lib/python2.7/threading.py", line 404, in wait
File "/usr/lib/python2.7/threading.py", line 259, in wait
<type 'exceptions.TypeError'>: 'NoneType' object is not callable

[svinota]

Thanks for reporting!

[svinota]

Fixed. Please notice, that now usage of .release() routines is required :

from pyroute2 import IPRoute
ip = IPRoute()
[…]
ip.release()

and the same for IPDB:

from pyroute2 import IPDB
ipdb = IPDB()
[…]
ipdb.release()

The .release() routine must be called even in the case of exceptions, so it is better to call it from finally clause:

from pyroute2 import IPRoute
ip = IPRoute()
try:
    […]
except […]:
    […]
finally:
    ip.release()

I had to remove the deamonic flag from threads a long time ago, but didn't 'cause of the interactive interpreter. Now they become daemons only when one runs pyroute2 from the interactive Python shell, otherwise one must explicitly call .release() to initiate the shutdown sequence of the object.

Is that ok?

[crane-denny]

works like a charm!
Thx for the quick fix. :)

[svinota]

You're welcome!