Implement serde::Serialize and serde::Deserialize for Ksuid structs. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrl5
force-pushed
the
implement-serde-traits
branch
2 times, most recently
from
5ba172d
to
7496d9d
Compare
tasn
reviewed
Oct 10, 2022
mrl5
force-pushed
the
implement-serde-traits
branch
from
7496d9d
to
37d0a4e
Compare
this change covers this usecases: 1. as a `rust-ksuid` lib user I want to serialize to JSON structs that use Ksuid type 2. as a `rust-ksuid` lib user I want to deserialize from JSON to structs that use Ksuid type
mrl5
force-pushed
the
implement-serde-traits
branch
from
37d0a4e
to
416a34c
Compare
|
Ready to be merged? |
tasn
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
rust-ksuidlib user I want to serialize to JSON structs that use Ksuid typerust-ksuidlib user I want to deserialize from JSON to structs that use Ksuid typeSolution
Implement serde::Serialize and serde::Deserialize for Ksuid structs.