Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider switching base docker image to debian-slim #302

Closed
tasn opened this issue Mar 11, 2022 · 2 comments · Fixed by #331
Closed

Consider switching base docker image to debian-slim #302

tasn opened this issue Mar 11, 2022 · 2 comments · Fixed by #331
Assignees
@tasn
Labels
server Issues regarding the server component

Comments

@tasn
Copy link
Member

tasn commented Mar 11, 2022

See comment on HN: https://news.ycombinator.com/item?id=30635160

Maybe it doesn't affect us, if we are using a rust implementation of DNS, but I'm not sure. Need to check what rust-tls does. Though maybe it's a good idea to switch.
@tasn tasn added the server Issues regarding the server component label Mar 11, 2022
@dkryptr
Copy link

dkryptr commented Mar 14, 2022

Another option could be to use https://github.com/GoogleContainerTools/distroless (they have a rust example).

If distroless is used, it nullifies the wait-for script since it uses nc and wget which likely aren't available in the image. But that could also be an opportunity to bake the waiting and retrying connections to postgres/redis into the server itself during initialization (if it doesn't already).

@tasn
Copy link
Member Author

tasn commented Mar 14, 2022

Yeah, I really want to add "wait-for", and to be honest, reconnecting into the Rust binary itself, so it's probably a good idea.

@tasn tasn self-assigned this Mar 21, 2022
tasn added a commit that referenced this issue Mar 21, 2022
@tasn
Change base Docker image to debian-slim
f5e4e31 
musl is claimed to have performance issues and random DNS bugs.
It's just not worth the hassle, especially given debian-slim should be
fine.

Ref: https://news.ycombinator.com/item?id=30635160

Fixes #302
@tasn tasn mentioned this issue Mar 21, 2022
Merged
tasn added a commit that referenced this issue Mar 21, 2022
@tasn
Change base Docker image to debian-slim
581aa29 
musl is claimed to have performance issues and random DNS bugs.
It's just not worth the hassle, especially given debian-slim should be
fine.

Ref: https://news.ycombinator.com/item?id=30635160

Fixes #302
@tasn tasn closed this as completed in #331 Mar 21, 2022
tasn added a commit that referenced this issue Mar 21, 2022
@tasn
Change base Docker image to debian-slim (#331)
9a5d191 
musl is claimed to have performance issues and random DNS bugs.
It's just not worth the hassle, especially given debian-slim should be
fine.

Ref: https://news.ycombinator.com/item?id=30635160

Fixes #302
@tasn tasn mentioned this issue Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tasn tasn

Labels
server Issues regarding the server component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change base Docker image to debian-slim svix/svix-webhooks
2 participants
@tasn @dkryptr