Update libraries to support multiple MessageStatus filters when getting messages #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-dylan
force-pushed
the
feature/filter-by-pending-sending
branch
from
85cf0de
to
28201b4
Compare
|
We're well past the point where we can just ship breaking changes like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, filtering by message status when listing attempted messages is constrained to filtering by just one status (eg "MessageStatus.Success"). However, it would be useful to filter by multiple statuses, particularly for statuses like MessageStatus.Pending and MessageStatus.Sending. This PR updates our libraries to support that behavior.