/settings endpoint is pinged in a endless loop

[danlutz]

Hi!

Your plugin is great! It worked very fine until now, but after upgrading to the latest version, I noticed in the chrome network tab that the /settings endpoint is pinged in a endless loop, which causes all components that are subscribed to the context to rerender on every ping.

Did you already notice this problem (and know an easy fix for this)?

You can see it an example on:

https://deploy-preview-5--ntrepreneur.netlify.com/

If you need any further code snippets, or have any questions, feel free to ask!

[jlengstorf]

I just ran into this as well — it causes an endless render loop for components using useIdentityContext() as well. Repro here: https://github.com/jlengstorf/netlify-identity-loop-bug

[alexkrolick]

🕵 Pretty sure the issue is that the API call to get settings always returns a new object and that causes useEffect to infinite loop when the value is set in state and then read back out as the effect dependency.

1. https://github.com/sw-yx/react-netlify-identity/blob/2abd831b5139dacde926152839ee966db76586bc/src/index.tsx#L131-L135

2. https://github.com/netlify/gotrue-js/blob/969c2fa5a0a11c2d392b039d70d54ac482bdde31/src/index.js#L47

3. https://github.com/remerge/micro-http-client/blob/bf69f8c3dc7cea05b2ed5b74e90537ae40f7371b/src/reducers.js#L41

---

Most likely introduced here when the identity was changed from a useMemo result to a state + effect: 77099a3

[swyxio]

so sorry for this bug guys, indeed i didnt notice it in my limited testing. i’ll try to fix but my confidence is a bit low since i failed to even detect this the first time.

[swyxio]

alright i think this is fixed in 0.1.7. please confirm?

the answer was really a two parter - a typo between settings and _settings on my end, but also i needed that memo around useNetlifyIdentity. e92f779#diff-38682f47b0cf12c516bc3714fc45d0fd

took a while to debug because my testing strategy sucks for this.

anyway, please update and it should work, let me know.

[swyxio]

here is my fork of @jlengstorf's thing with the updated thing and the infinite loop is gone (jason: i had to add gatsby-ssr which you seemed to have forgotten. i guess this is the plugin we talked about! super busy this week but happy to work this up next week): see the final demo here https://hungry-yonath-ed6433.netlify.com/

as a side note, the widget css is a bit leaky, i have filed an issue to namespace here

[jlengstorf]

@sw-yx the fix works, but uses nested hooks, so we get warnings. I think the useMemo call needs to be moved inside the useNetlifyIdentity definition and/or it needs to use a non-hook memoization function?

[swyxio]

@jlengstorf sorry it took a while, but i've updated r-n-i to 0.1.8 and r-n-i-w to 0.1.4 (should probably sync their versions or move into monorepo...) with the useMemo moved down... hope that fixes it! it does as far as i can tell here.