feat: add reference related metadata to namespaces #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char0n
reviewed
Jul 30, 2021
There was a problem hiding this comment.
If the purpose of this PR was to provide complete referencing metadata support via metadata, then we're still missing some objects that can support referenceing
This is for openapi:
const canHaveReference = (element) => {
return (
isReferenceElement(element) ||
(isSchemaElement(element) && isStringElemenet(element.$ref)) ||
(isExampleElement(element) && isStringElement(element.externalValue)) ||
(isPathItemElement(element) && isStringElement(elemenet.$ref)) ||
(isLinkElement(element) && isStringElement(element.operationRef))
);
};Asyncapi have Reference Object and Channel Item Object
...ackages/apidom-ns-asyncapi-2-0/src/refractor/visitors/async-api-2-0/reference/$RefVisitor.ts
Outdated
Show resolved
Hide resolved
| methods: { | ||
| StringElement(stringElement: StringElement) { | ||
| this.element = stringElement.clone(); | ||
| this.element.classes.push('reference-field'); |
apidom/packages/apidom-ns-openapi-3-1/src/refractor/visitors/open-api-3-1/schema/$refVisitor.ts
Outdated
Show resolved
Hide resolved
| // get current $ref keyword | ||
| const $ref = objectElement.get('$ref')?.toValue(); | ||
|
|
||
| // if it's a non empty strings |
There was a problem hiding this comment.
nitpick: would drop the comment here; it doesn't express anything else then the following declarative assertion
apidom/packages/apidom-ns-openapi-3-1/src/refractor/visitors/open-api-3-1/schema/index.ts
Outdated
Show resolved
Hide resolved
char0n
reviewed
Jul 30, 2021
...ckages/apidom-ns-openapi-3-1/src/refractor/visitors/open-api-3-1/link/OperationRefVisitor.ts
Show resolved
Hide resolved
char0n
reviewed
Jul 30, 2021
char0n
reviewed
Jul 30, 2021
apidom/packages/apidom-ns-openapi-3-1/src/refractor/visitors/open-api-3-1/schema/index.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.