Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] inconsistent version 2.1.6 in mavencentral with current code in github #2949

Closed
martinmuellerrohde opened this issue May 24, 2016 · 12 comments

Comments

@martinmuellerrohde
Copy link

martinmuellerrohde commented May 24, 2016

Note: we noticed CodegenModel.java with Map<String, Object> allowableValues is missing in a Swagger-codegen jar downloaded from Maven-central.

There seems to be an inconcistency:

If Maven retrieves version 2.1.6 from maven-central it gets the version with CodegenModel.java where allowableValuesis represented as a List<String>.

If downloading the latest code from github it also creates a version 2.1.6 but this time with CodegenModel.java where allowableValuesis represented as a Map<String, Object>.

In other words:
The releases tagged as 2.1.6 doesn't contain your great additions in CodegenModel.java for enum key/value-pairs.
Even though thoses changes were prior to 2.1.6 they are not included in the release dated from April 6th 2016.

I really would like to use the new enum-features and don't know how to make my build-process stable if it downloads the wrong version.

Swagger-codegen version: 2.1.6

Proof:
Compare content of
http://central.maven.org/maven2/io/swagger/swagger-codegen/2.1.6/swagger-codegen-2.1.6.jar
with your latest code.

Suggestion:
a) change the version in your pom.xml from 2.1.6 to 2.1.7-SNAPSHOT
b) tag the latest code with Map<String, Object> allowableValues to make it available for download via mavencentral

@wing328
Copy link
Contributor

wing328 commented May 25, 2016

@martinmuellerrohde I've merged #2950 into master to update the version to 2.2.0-SNAPSHOT (which is the next stable version)

@wing328 wing328 added this to the v2.2.0 milestone May 25, 2016
@martinmuellerrohde
Copy link
Author

martinmuellerrohde commented May 25, 2016

Thank you @wing328 !
Currently your README.md still says "2.1.7-SNAPSHOT" even though it is 2.2.0-SNAPSHOT now.

@wing328
Copy link
Contributor

wing328 commented May 25, 2016

@martinmuellerrohde updated :)

@wing328
Copy link
Contributor

wing328 commented May 25, 2016

For allowableValues it's a breaking change due to the need to have better enum support. Please refer to #2508 (comment) for more information.

@martinmuellerrohde
Copy link
Author

Super !
Now I guess I still need it to be published at maven central, right?

@wing328
Copy link
Contributor

wing328 commented May 25, 2016

@martinmuellerrohde I do not have right to do that. I think @fehguy and @webron are busy at the CloudFoundry Summit.

Can you do a mvn install to install the 2.2.0-SNAPSHOT version locally for the time being?

@fehguy
Copy link
Contributor

fehguy commented May 25, 2016

Hi, we are definitely not ready to release 2.2.0, but we can do a patch release of 2.1.7 whenever @wing328 is ready.

@wing328
Copy link
Contributor

wing328 commented May 25, 2016

@martinmuellerrohde it usually takes 3 to 4 months to release a stable version. I think your request is to upload 2.2.0-SNAPSHOT (not 2.2.0) to maven repo for the time being, right?

@fehguy
Copy link
Contributor

fehguy commented May 25, 2016

I would suggest that we don't do that though, because 2.2.0 will have some major changes in packaging and it'll break @martinmuellerrohde 's deployment when that happens...

@martinmuellerrohde
Copy link
Author

martinmuellerrohde commented May 25, 2016

Oh, yes.
You are right.
A patch version 2.1.7 would be a lot nicer.

@martinmuellerrohde martinmuellerrohde changed the title [Java] inkonsistent version 2.1.6 in mavencentral with current code in github [Java] inconsistent version 2.1.6 in mavencentral with current code in github May 26, 2016
@heikom71
Copy link

heikom71 commented Jun 24, 2016

Same problem like @martinmuellerrohde in my project - a patch version 2.1.7 would be fantastic...

@wing328
Copy link
Contributor

wing328 commented Jul 7, 2016

We'll release 2.2.0 soon.

Closing this issue.

@wing328 wing328 closed this as completed Jul 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants