-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1482 refactor #1611
Merged
Merged
Issue 1482 refactor #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: modules/swagger-jaxrs/src/main/java/io/swagger/jaxrs/config/WebXMLReader.java
@webron it should actually possibly solve it, I just updated last remaining unchecked ref to context (kind of quick fix, ReaderConfig still only configurable via context), but tests and samples would need to be run/checked to confirm |
I've verified this works. There is a slight change in usage though--as shown in the samples, this:
has been replaced with this:
We'll update the release notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @fehguy, PR aims at fixing and references issues #1482 #1384, PR #1397.
It basically allows to configure more than one "Swagger context" (logical concept including SwaggerConfig, Swagger initial info and used Scanner instance) in same JVM and same web application, one for each configured servlet/servletConfig.
An example of "multi context" setup can be find in samples project PR swagger-api/swagger-samples#46
where a "swagger.context.id" initParam is provided for each separate "swagger context" instance (see sample web.xml)
Approach is sub-optimal, but as discussed quite some additional refactor would be needed to accomplish a nicer solution, with quite high risk related to compatibility.