fix(monaco-language-apidom): completion filtering #4269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kowalczyk-krzysztof this can be a solution, but I would rather address it in underlying completion provider (in apidom-ls This is possibly related to swagger-api/apidom#2734, even if the change there shouldn't theoretically cause the reported behavior. As a tech note possibly this function can be related I can have a look tomorrow/thursday |
|
swagger-api/apidom#2734 shouldn't cause this as it's been released in https://github.com/swagger-api/swagger-editor/releases/tag/v5.0.0-alpha.58 Here is the alpa.41 manifesting the same behavior: https://swagger-editor-dsl.surge.sh/ |
|
I agree with @frantuma, we should address this in ApiDOM, as it's single source of truth for the completion items. Fixing it here would only solve issue with SwaggerEditor. |
kowalczyk-krzysztof
deleted the
fix-completition-item-provider-subsequence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #4216
The implementation filters out completion items which have labels that don't contain the input as a subsequence.