New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(http): refactor http client #3482

Merged

glowcloud merged 3 commits into master from issue-3481

Apr 24, 2024

Contributor

glowcloud commented Apr 23, 2024

Refs #3481

Moved request and response serializing/encoding into separate files
Moved the logic introduced by fix(execute): fix encoding for stringified request body #3476 and fix(execute): parse stringified objects #3474 to request builder


          refactor(http): refactor http client

35a2f47

Refs #3481

glowcloud added the type: enhancement label

glowcloud requested a review from char0n

April 23, 2024 13:22

glowcloud self-assigned this

Contributor Author

glowcloud commented Apr 23, 2024

For placement of response and request serializers - mergeInQueryOrForm is also used in one place in execute, but it's also for building requests, so it still seemed related to http
I also thought about leaving index in http just for exports - let me know if that would be better and the functions should be moved to an additonal file, ex. http.js
file and format functions are only used for request serializing/encoding and in tests, so also looks like it's an appropriate place for them to be

char0n reviewed

View reviewed changes

src/http/index.js Outdated Show resolved Hide resolved

char0n reviewed

View reviewed changes

src/http/index.js Outdated Show resolved Hide resolved

char0n reviewed

View reviewed changes

src/http/serializers/response/index.js Outdated Show resolved Hide resolved

char0n reviewed

View reviewed changes

src/http/serializers/request/index.js Outdated Show resolved Hide resolved

char0n reviewed

View reviewed changes

src/http/serializers/request/index.js Outdated Show resolved Hide resolved

char0n requested changes

View reviewed changes

Member

char0n left a comment

Looks cleaner and more maintainable for sure. Nicely done!

Please have a look at my CRCs.

char0n reviewed

View reviewed changes

src/http/index.js Outdated Show resolved Hide resolved


          apply requested changes

1a19c79

glowcloud commented

View reviewed changes

src/http/index.js Outdated Show resolved Hide resolved

char0n approved these changes

View reviewed changes

Member

char0n left a comment

Let's process https://github.com/swagger-api/swagger-js/pull/3482/files#r1577376938 and "squash + merge"


          update serializeHeaders export

cce366a

glowcloud merged commit c4198da into master

5 checks passed

glowcloud deleted the issue-3481 branch

April 24, 2024 07:15

glowcloud mentioned this pull request

Consolidate code for HTTP client #3481

Closed

char0n pushed a commit that referenced this pull request


          fix(http): fix parsing null values when building requests (#3498)

8846cc7

Refs #3482

swagger-bot pushed a commit that referenced this pull request


          chore(release): cut the 3.27.3 release [skip ci]

10cbc2e

## [3.27.3](v3.27.2...v3.27.3) (2024-05-06)

### Bug Fixes

* **http:** fix parsing null values when building requests ([#3498](#3498)) ([8846cc7](8846cc7)), closes [#3482](#3482)

Contributor

swagger-bot commented May 6, 2024

🎉 This PR is included in version 3.27.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

swagger-bot added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment