support of the allOf inside array(items)

[PavelPolyakov]

Hi,

Couple of examples.

This one is basic, and it works:

  responses:
    200:
      schema:
        type: array
        items:
          type: object
          properties:
            a:
              type: string
            b:
              type: string

Here is the one with allOf, but not inside items:

  responses:
    200:
      schema:
        allOf:
          - $ref: ../../definitions/structures/industry.yaml
          - properties:
              id:
                type: integer
                format: int64

Works:

And here is the one using allOf and array as response structure:

  responses:
    200:
      schema:
        type: array
        items:
          allOf:
            - $ref: ../../definitions/structures/industry.yaml
            - properties:
              id:
                type: integer
                format: int64

Which results to this:

Does not work.

It this an issue?

Regards,

[webron]

Looks like.

[vellotis]

+1

[jpautom]

+1

[orbit-dna]

+1
a simple example here:

swagger: '2.0'
info:
  title: API
  version: "1.0.0"
basePath: /api
paths:
  /path:
    get:
      responses:
        200:
          schema:
            type: array
            items:
              type: object
              allOf:
                - properties:
                    id:
                      type: integer
        default:
          schema:
            type: string

the result in swagger-ui:

[
  {}
]

However, this works:

swagger: '2.0'
info:
  title: API
  version: "1.0.0"
basePath: /api
paths:
  /path:
    get:
      responses:
        200:
          schema:
            type: object          # differ here
            properties:           # differ here
              array:              # differ here
                type: array
                items:
                  type: object
                  allOf:
                    - properties:
                        id:
                          type: integer
        default:
          schema:
            type: string

Seems only fail when the array dirrectly under schema

[lmanco]

+1

[dnascimento]

+1

[iericzhu]

+1

[leonliem]

+1

[gnozell]

I'm getting the same error

From this json

    "swagger": "2.0",
    "info": {
        "version": "0.0.0",
        "title": "Simple API"
    },
    "responses": {
        "200": {
            "description": "test",
            "schema": {
                "allOf": [
                    {
                        "type": "object",
                        "properties": {
                            "description": {
                                "type": "string"
                            }
                        }
                    }
                ]
            }
        },
        "201": {
            "description": "test",
            "schema": {
                "type": "object",
                "properties": {
                    "description": {
                        "type": "string"
                    }
                }
            }
        }
    },
    "paths": {
        "/works": {
            "get": {
                "responses": {
                    "200": {
                        "description": "test",
                        "schema": {
                            "type": "object",
                            "properties": {
                                "description": {
                                    "type": "string"
                                }
                            }
                        }
                    }
                }
            }
        },
        "/works_with_refs": {
            "get": {
                "responses": {
                    "200": {
                        "$ref": "#/responses/201"
                    }
                }
            }
        },
        "/works_with_allOf": {
            "get": {
                "responses": {
                    "200": {
                        "description": "test",
                        "schema": {
                            "allOf": [
                                {
                                    "properties": {
                                        "description": {
                                            "type": "string"
                                        }
                                    },
                                    "type": "object"
                                }
                            ]
                        }
                    }
                }
            }
        },
        "/doesnt_work_refs_and_refs": {
            "get": {
                "responses": {
                    "200": {
                        "$ref": "#/responses/200"
                    }
                }
            }
        }
    }

I notice this has been open for a year is there any progress as to what might be causing the issue or were to begin looking?

[webron]

We're working on a major update to the project that should resolve this issue and others. Before you ask, I'm afraid I don't have an ETA.

[IanGallacher]

Any updates on the ETA?

[webron]

A few weeks.

[jonathanhuet]

+1

[JLLeitschuh]

I could potentially dive in and try to fix this problem if someone could give me some direction on where to start.

[webron]

Honestly, I wouldn't bother. We're very close to releasing a new major version of swagger-ui (just a few weeks away) and I know this issue doesn't exist in it.

[JLLeitschuh]

Oh, awesome.
What branch is this on? We would love to pull that code in and run it on our (internal company) servers if it's been fixed.

[webron]

It's not public yet.

[jonathanhuet]

Working! Thanks!!

PD: What a huge update (clap)

[webron]

This is supported and working in 3.0.