Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty div if there are properties #4236

Merged
merged 3 commits into from
Mar 9, 2018
Merged

Add empty div if there are properties #4236

merged 3 commits into from
Mar 9, 2018

Conversation

heldersepu
Copy link
Contributor

@heldersepu heldersepu commented Feb 20, 2018 •
edited
Loading

Description

See Issue #4134

Motivation and Context

Partially_Fixes #4134

Screenshots (if appropriate):

Before:
image

After:
image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@heldersepu
Add empty div
6eeead2 
if there are properties show an empty div
@webron webron requested a review from shockey February 20, 2018 02:49
@shockey
Copy link
Contributor

shockey commented Feb 27, 2018

@heldersepu, I don't see a difference between your two screenshots, can you point out what changed?

@heldersepu
Copy link
Contributor Author

heldersepu commented Feb 27, 2018 •
edited
Loading

@shockey Added an empty div if there are properties, that will break into multiple lines like it does when there is a description.

These are the lines that this PR improves:
image
image
In these images those blue bold string will break into the next line

shockey
shockey approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@shockey shockey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shockey shockey merged commit ad57f5a into swagger-api:master Mar 9, 2018
shockey pushed a commit to scottohara/swagger-ui that referenced this pull request Mar 12, 2018
@heldersepu @shockey
Add empty div (swagger-api#4236)
2c76d02 
if there are properties show an empty div
shockey pushed a commit that referenced this pull request Mar 12, 2018
@scottohara @shockey
improve: show possible reasons when url fetch fails (#4295)
fb7f125 
* improve: show possible reasons when url fetch fails
* Only check for fail reasons if no HTTP status code
* Check for mixed content errors first
* Harmonise error messages
* Set error source to 'fetch'
* improve: hide loading validator image (#4287)
* hide missing validator image
* Render nothing if validator badge has not loaded/received errors
* Revert style changes
* Allow images with data scheme (#4305)
* Add UnitTest for image
allows image elements with https scheme
* Test images with data scheme
* Add allowedSchemesByTag
* Fix error  Strings must use doublequote  quotes
* Add empty div (#4236)
if there are properties show an empty div
* v3.12.1 (#4311)
* v3.12.1
* Rebuild dist for v3.12.1
* Use window wrapper instead of direct reference
* Add trailing period to error messages
* improve readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shockey shockey shockey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heldersepu @shockey