Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/array item schema #7007

Merged
merged 4 commits into from
Mar 3, 2021
Merged

Conversation

mathis-m
Copy link
Contributor

Description

Fixes wrong array items schema selection logic, for the schema which will passed to jsonschema components.

items.schema is not defined in oas. Instead the schema is directly under items.

I also enhanced the ui by adding type text to add button:
image

Motivation and Context

Fixes #6326

How Has This Been Tested?

Not

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

mathis-m and others added 4 commits February 27, 2021 02:13
this makes no sense items.schema is not defined by oas

Signed-off-by: mathis-m <mathis.michel@outlook.de>
this is to enhance nested array usability wise

Signed-off-by: mathis-m <mathis.michel@outlook.de>
@tim-lai tim-lai merged commit 2016c18 into swagger-api:master Mar 3, 2021
@tim-lai
Copy link
Contributor

tim-lai commented Mar 3, 2021

@mathis-m PR merged! Thanks for the fix. Fyi, the feat(ux) would have been better as a separate PR, but I noticed it too late. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"😱 Could not render n, see the console." when providing nested lists.
2 participants