Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator badges not being rendered on Github #110

Open
harrisj opened this issue May 17, 2017 · 6 comments
Open

Validator badges not being rendered on Github #110

harrisj opened this issue May 17, 2017 · 6 comments

Comments

@harrisj
Copy link

harrisj commented May 17, 2017

GitHub seems to proxy images and for some reason the badge is not making it through that process correctly. So, you see a broken image on the page and a link going to a URL like https://camo.githubusercontent.com/<long_hash_string> that is 404ing. You can see the failure on your own README. I have tried flipping it to use a https URL instead (since camo is for wrapping insecure image requests), but that doesn't seem to have made a difference. Given that many people put badges on their README.md, this is likely to affect many users. Thanks!

@fehguy
Copy link
Contributor

fehguy commented May 17, 2017

Unfortunately that's how GitHub is handling dynamic requests. I don't know of a way around it.

@harrisj
Copy link
Author

harrisj commented May 17, 2017

Well, is it possible that we could trick Github by allowing a request to validator.svg (or whatever the type of the image is)?

@fehguy
Copy link
Contributor

fehguy commented May 17, 2017

I think this is intentional with GH, it's how they avoid people sneaking tracking scripts into pages. I'm not an expert in it, and it changes often but I've seen this happen where you save the page and instead of rendering a dynamic image, they'll make a copy and save it in their CDN.

@harrisj
Copy link
Author

harrisj commented May 18, 2017

Ah well, I've had to remove the badge from our README, but I would like to be able to add it back in the future if this ever gets resolved. Thank you.

@cptaffe
Copy link
Contributor

cptaffe commented Aug 23, 2017

@fehguy they just cache the image for whatever the Cache-Control is set to

@MikeRalphson
Copy link

Possible dupe of #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants