Skip to content

Conversation

char0n
Copy link
Member

@char0n char0n commented Mar 17, 2025

Refs #13

@char0n char0n requested a review from Copilot March 17, 2025 21:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Map/Set evaluation by introducing a new evaluation realm that handles Map and Set instances, and updates tests and documentation accordingly.

  • Introduces MapSetEvaluationRealm to enable JSON Pointer evaluation on Map and Set objects.
  • Adds comprehensive test cases in test/evaluate/realms/map-set.js.
  • Updates README.md to document the new Map/Set Evaluation Realm.
  • Updates test/evaluate/index.js for consistency with RFC 6901 naming and improved testing practices.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/evaluate/realms/map-set.js Implements evaluation logic specifically for Map and Set objects.
test/evaluate/realms/map-set.js Adds tests covering various JSON Pointer evaluation scenarios for Map/Set.
README.md Documents the usage and functionality of the new Map/Set Evaluation Realm.
test/evaluate/index.js Refactors test descriptions and imports to align with updated standards.
Comments suppressed due to low confidence (1)

test/evaluate/realms/map-set.js:79

  • The test description mentions an array while the expected return value is a Set. Consider updating the description to accurately describe the return type as a Set.
specify('should return array ["bar", "baz"] for "/foo"', function () {

@char0n char0n self-assigned this Mar 17, 2025
@char0n char0n merged commit 4e16890 into main Mar 17, 2025
4 checks passed
@char0n char0n deleted the char0n/map-set-realm branch March 17, 2025 21:36
char0n pushed a commit that referenced this pull request Mar 17, 2025
# [1.4.0](v1.3.0...v1.4.0) (2025-03-17)

### Features

* **evaluate:** add support for Map/Set realm ([#15](#15)) ([4e16890](4e16890)), closes [#13](#13)
@char0n
Copy link
Member Author

char0n commented Mar 17, 2025

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant