Implement support for multiple HTTP success statuses #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `OutputWithHTTPStatus` is implemented on the output port, `HTTPStatus()` defines the success HTTP status of a given operation, and `ExpectedHTTPStatuses()` defines all expected HTTP statuses for API documentation purposes.
|
@vearutop, any feedback is very welcome! In particular, I wasn't quite sure about the naming of this new interface and its methods, and which package exactly it should be. |
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 77.68% 77.67% -0.02%
==========================================
Files 28 28
Lines 1600 1608 +8
==========================================
+ Hits 1243 1249 +6
- Misses 235 236 +1
- Partials 122 123 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
haimgel
force-pushed
the
feature/multiple-success-http-statuses
branch
from
65e5f34
to
794fde0
Compare
|
Thank you, looks good! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
OutputWithHTTPStatusis implemented on the output port,HTTPStatus()defines the successful HTTP status of a given operation, andExpectedHTTPStatuses()defines all expected HTTP statuses for API documentation purposes.See #153 for the discussion about this feature.