Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set env CGO_ENABLED=0 for goreleaser to avoid dynamic linking #1293

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

csiwek
Copy link
Contributor

@csiwek csiwek commented Aug 12, 2022

Binaries that are being built by the goreleaser don't have the CGO_ENABLED=0 env set which means they are dynamically linked to
/lib64/ld-linux-x86-64.so.2 (or whichever version of ld-linux)
In some versions of distros, there are different versions ld-linux which makes the swag not start properly.
In my case, I wanted to download the release binary into intermediate docker based on alpine to generate API documentation and it was always failing with "file not found" error.
NOTE: This change was not tested - I don't have the whole setup to test the goreleaser
sources:
https://jvns.ca/blog/2021/11/17/debugging-a-weird--file-not-found--error/
https://goreleaser.com/customization/build/

Describe the PR
Add CGO_ENABLED=0 into .goreleaser

Relation issue

Additional context

Binaries that are being built by the goreleaser don't have the CGO_ENABLED=0 env set which means they are dynamically linked to 
/lib64/ld-linux-x86-64.so.2  (or whichever version of ld-linux)
In some versions of distros, there are different versions ld-linux which makes the swag not start properly. 
In my case, I wanted to download the release binary into intermediate docker based on alpine to generate API documentation and it was always failing with "file not found" error.
NOTE: This change was not tested - I don't have the whole setup to test the goreleaser
sources:
https://jvns.ca/blog/2021/11/17/debugging-a-weird--file-not-found--error/
https://goreleaser.com/customization/build/
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan
Copy link
Contributor

ubogdan commented Aug 16, 2022

@csiwek Thanks for letting us know. I will use this with the next release to see what's going to happen.

@ubogdan ubogdan merged commit 23661ef into swaggo:master Aug 16, 2022
@ubogdan
Copy link
Contributor

ubogdan commented Aug 16, 2022

@csiwek Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants