Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/httpreq package #4

Merged
merged 4 commits into from
Mar 12, 2022
Merged

Feat/httpreq package #4

merged 4 commits into from
Mar 12, 2022

Conversation

R-Loic
Copy link

@R-Loic R-Loic commented Feb 21, 2022 •
edited
Loading

Init httpreq package

  • Init request struct
  • create execute function to send http request
  • create tracer struct to save http request details

@R-Loic R-Loic marked this pull request as draft February 21, 2022 20:00
@R-Loic R-Loic changed the title [WIP] Feat/httpreq package Feat/httpreq package Mar 2, 2022
@R-Loic R-Loic marked this pull request as ready for review March 2, 2022 10:23
Anthony-Jhoiro
Anthony-Jhoiro reviewed Mar 4, 2022
View reviewed changes
engine/httpreq/tracer.go
}

func now() int64 {
return time.Now().UnixNano()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not store it as a time.Time directly?

engine/httpreq/httpreq.go Show resolved Hide resolved
@Anthony-Jhoiro Anthony-Jhoiro self-requested a review March 11, 2022 16:10
@R-Loic R-Loic merged commit e9d88c2 into main Mar 12, 2022
@R-Loic R-Loic deleted the feat/httpreq_package branch March 20, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anthony-Jhoiro Anthony-Jhoiro Anthony-Jhoiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@R-Loic @Anthony-Jhoiro