Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

job-table: sort stages by id #18

Merged
merged 1 commit into from
May 9, 2022
Merged

job-table: sort stages by id #18

merged 1 commit into from
May 9, 2022

Conversation

utkarshgupta137
Copy link
Contributor

No description provided.

krishnan-r
krishnan-r approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@krishnan-r krishnan-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @utkarshgupta137

@krishnan-r krishnan-r merged commit 83d79df into swan-cern:master May 9, 2022
@utkarshgupta137
Copy link
Contributor Author

utkarshgupta137 commented May 9, 2022 •
edited
Loading

Actually, this is not working properly. JavaScript doesn't sort numbers in the natural order (10 is coming before 1). I'll raise another PR for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnan-r krishnan-r krishnan-r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utkarshgupta137 @krishnan-r