shade json4s in scalalistener #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucaCanali
previously approved these changes
Dec 8, 2021
There was a problem hiding this comment.
I understand this has been tested on a swan test instance by @rccern and it's working OK.
Minor point: I would bump up the spark 3 version dependency, for example to Spark 3.2.0.
The change looks good to me.
dungdm93
reviewed
Dec 10, 2021
|
@dungdm93 thanks, I had added the plugins file in gitignore, but it didn't work because the directory above was excluded and put back org.json4s in the shaded class names, it makes it more easy to understand @LucaCanali bumped spark to 3.2.0 |
krishnan-r
approved these changes
Jan 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark 3.2 changed version of json4s, shading helps have a single codebase compatible for spark 2.4, 3.0, 3.1, 3.2