Skip to content

Conversation

keliwang
Copy link
Contributor

I'm going to add a feature that you can starred a story which you like just like GR. So that you can set all the stories you like into a list. I have already

  • Add a new /starred page to show all starred stories
  • Add star option to the story's action bar
  • Add a new button link to /starred page
  • Add English and Chinese locales

Known problems

  • Localized text for some languages are missing
  • Need write some tests for this new feature

Some screenshots

  • New button which use icon-star

feed_bar

  • star option's two statuses

star
starred

This feature still need some work to do. And I'm looking forward to your advice.

@swanson
Copy link
Collaborator

swanson commented May 18, 2013

Looks like you are off to a good start - let's use s for the hotkey (to match GReader).

Personally I don't use stars but I think this feature fits fine with the project.

@keliwang
Copy link
Contributor Author

@swanson OK, I'll add that.

@swanson
Copy link
Collaborator

swanson commented May 20, 2013

@edgarwang is there anything left for this feature?

@keliwang
Copy link
Contributor Author

@swanson Yes, I'm still working on it. Please see the screenshot below.

a

I'm add another star icon before feed title so that users can star/unstar an item in a more convenient way.
In this way, users can also see items' status in a direct way.

I'm a little busy these days. Sorry about the slow progress. I'll complete this feature in a day or two.

@swanson
Copy link
Collaborator

swanson commented May 20, 2013

@edgarwang No rush - just wanted to know if you were still working. Don't be sorry at all :)

keliwang added 2 commits May 21, 2013 10:55
Fix a bug: add stopPropagation to escape open a story when you click on
the star icon.
@keliwang
Copy link
Contributor Author

@swanson This feature is complete now. You can merge it and close this issue now. Thank you.

@swanson swanson merged commit 4819cbb into stringer-rss:master May 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants