Skip to content

Conversation

chrishunt
Copy link
Contributor

A start to #33

This adds:

  • /feeds/refresh for fetching all feeds
  • /feeds/:feed_id/refresh for fetching a feed given an id

Thoughts?

I'm happy to change the verb to POST if you feel strongly about it, but GET made sense to me.

@rricard
Copy link

rricard commented Jun 3, 2013

This is a good idea. I'm tired of waiting one hour to see my feeds refreshed.

@swanson
Copy link
Collaborator

swanson commented Jun 3, 2013

This could potential take a while if you have a lot of feeds (and will cause timeouts on Heroku) - might be best to throw them into the DelayedJob queue with FetchFeeds#enqueue.

My intention with #33 was to allow me to leave the tab open and have it refresh (on the hour) when new stories came in - I'm not quite convinced that manual triggering has much value.

@chrishunt
Copy link
Contributor Author

@swanson Ah, I see. I got the impression in #33 you wanted a webhook to hit with JS in the background to refresh. Feel free to close the issue.

It sounds like what we really want is a way to ask 'have any new stories been fetched?' and, if so, update the content.

@swanson
Copy link
Collaborator

swanson commented Jun 3, 2013

Ya #33 was not super clear - I misunderstood what Fever meant by auto refreshing.

I think something like:

wait 5 minutes
poll if any new unread stories have been added
if so, render the new stuff

It gets a bit tricky because you don't want to do weird stuff with rendering if the user is just reading a long article. Maybe something like how Twitter does the new messages when you have the page open would be better.

@swanson swanson closed this Jun 3, 2013
@swanson swanson mentioned this pull request Jun 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants