Skip to content

Conversation

dgutov
Copy link
Contributor

@dgutov dgutov commented May 12, 2013

When feed item body has images/videos with relative URLs, currently they cause requests to the server where the app is hosted, resulting in 404s and sometimes 302s (sinatra/rack-protection#56).

I've seen an opinion that such feeds are not valid, but Google Reader supports that, so I think you should, too. Example: https://www.google.com/reader/view/#stream/feed/http://nakkaya.com/rss-feed

@swanson swanson merged commit 3ffeefa into stringer-rss:master May 13, 2013
@swanson
Copy link
Collaborator

swanson commented May 13, 2013

This code is really elegant and works great. Thanks for tackling this - I had given up on being able to do this 👍

I made the spec match the style of the rest of the suite and made a nitpicky renaming of the method. Awesome job!

@dgutov
Copy link
Contributor Author

dgutov commented May 13, 2013

No problem, thanks for the cleanup!

I'm a bit surprised you're using # symbols in describe block names here, class method sections are often (usually?) named starting with . to distinguish them from instance methods.

Anyway, looks like I left an extraneous line of code in the new method (URI.parse(url), oops!), please delete that.

@swanson
Copy link
Collaborator

swanson commented May 13, 2013

Ah - you are right about # vs . - my bad there.

Will delete that for you, no problem!

swanson pushed a commit that referenced this pull request May 13, 2013
@dgutov dgutov deleted the absolute_urls branch November 30, 2013 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants