Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox and Chrome not working again #12

Closed
itstheandre opened this issue Jun 18, 2019 · 20 comments
Closed

Firefox and Chrome not working again #12

itstheandre opened this issue Jun 18, 2019 · 20 comments

Comments

@itstheandre
Copy link

Well, as explained on #9 and #10 it stopped working. Even after the update. For a few hours was working and now no longer.

@swapagarwal
Copy link
Owner

You have to click the page action button to read the full story. 😇

@gonz4lex
Copy link

Hi @swapagarwal,

Unfortunately, I can confirm what @itstheandre says. Clicking the page action button reopens the page in a new tab, but the member's only paywall is not removed.

@itstheandre
Copy link
Author

itstheandre commented Jun 19, 2019 via email

@swapagarwal
Copy link
Owner

swapagarwal commented Jun 19, 2019 via email

@itstheandre
Copy link
Author

itstheandre commented Jun 19, 2019 via email

@itstheandre
Copy link
Author

@swapagarwal I've tried signing out of medium and reupdating the extension but to no luck

@j3soon
Copy link
Collaborator

j3soon commented Jun 19, 2019

Hi, I can confirm this issue. Maybe try using incognito mode instead or other methods mentioned here for now.

@nicolas-b12
Copy link

Same here, doesn't work anymore...

@nicolas-b12
Copy link

Update : The method is still valid, if I copy the request as Curl, then add something like -H 'Referer: https://t.co/9mrinl90sv' it works

@KartSriv
Copy link

@swapagarwal I can also confirm that mediumship is not working.

@j3soon
Copy link
Collaborator

j3soon commented Jun 19, 2019

@nicolas-b12 Hi, can you elaborate more details on your approach?

@nicolas-b12
Copy link

nicolas-b12 commented Jun 19, 2019

Sure @j3soon I tested the trick that I used by this Chrome extension, first in curl to be sure that it works and yes, I could read the full article after downloading the page. Then I was thinking, could Chrome block now the fact that we can override the referrer ? So I took a known chrome extension that can overwrite the referrer so I set up a rule that change the referrer from medium.com to https://t.co/[somerandombase36] and it works. So the trick is totally working and something (I don't know what) is wrong in the code of this extension.

@nicolas-b12
Copy link

I found that you can't remove all the site rules, you need at least one rule by domain that you want to manipulate.

@j3soon
Copy link
Collaborator

j3soon commented Jun 19, 2019

Thanks @nicolas-b12 ! It's my mistake to remove those permissions. We still need them because of our singly-used background listener! I've roll backed the commit and updated both on Chrome & Firefox, try it out on v2.3.

@itstheandre Try out v2.3, It should work by clicking the button.

@swapagarwal
Copy link
Owner

Thanks @nicolas-b12 for diving into the issue! ❤️

@swapagarwal
Copy link
Owner

@itstheandre Can you confirm it's working for you now?

@gonz4lex
Copy link

Hi @swapagarwal ,

I can confirm it works on my side (Chrome) whenever clicking the action button, and for domains other than medium.com, i.e. towardsdatascience.com and itnext.io.

Great job from your side guys!

@itstheandre
Copy link
Author

@swapagarwal good on firefox :)

@nicolas-b12
Copy link

@swapagarwal @j3soon you're welcome, all credits to you ! You did an amazing job !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants