28 standarize decimal responses

[phoenix-web3]

Description

To standardize all responses that return a decimal number it is proposed to return all such responses in JSON number type.

Due to the poor implementation of the standard number type in languages like Javascript it may cause some problems in the future to return data as Number instead of String.

BTC

• getAddressBalance
• getAddressesBalance
• getAddressUnspent
• getBlockByNumber
• getFeePerByte
• getTransactionCount
• syncing

BCH

• getAddressBalance
• getAddressUnspent
• getBlockByNumber
• getFeePerByte
• getTransactionCount
• syncing

ETH

• estimateGas
• getAddressBalance
• getAddressesBalance
• getBlockByNumber
• getGasPrice
• getHeight
• getTransaction
• getTransactionCount
• syncing

Fixes #28 (issue)

Dependencies (if any)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Test has been passed for ETH and BTC:

Syncing method tested separately

curl -X POST --header 'Content-Type: application/json' --data '{"jsonrpc":"2.0","method":"syncing","params":{}, "id":1}' http://localhost:60001/rpc

{"id": 1, "jsonrpc": "2.0", "result": {"syncing": true, "syncPercentage": "0.038334007004731815%", "currentBlockIndex": 13160, "latestBlockIndex": 2133529}}

Test Configuration:

• Operating system (output of cat /etc/os-release):

NAME="Ubuntu"
VERSION="18.04.5 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.5 LTS"
VERSION_ID="18.04"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

• Kernel version (output of uname -sr): Linux 4.15.0-143-generic
• Architecture (output of uname -m): x86_64

Related PR or Docs PR

Docs PR related #
Other PR related swapper-org/swapper-core#25

Good practices to consider

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[hippocampusSwapper]

It would be nice if you could put a PR to reflect these changes also in the client side package.

Package: https://github.com/swapper-org/swapper-core/tree/develop/packages/swapper-nodechain-client
Docs: https://hippocampus.gitbook.io/swapper-1/repositorio-monorepo/packages/swapper-nodechain-client

[phoenix-web3]

It would be nice if you could put a PR to reflect these changes also in the client side package.

Package: https://github.com/swapper-org/swapper-core/tree/develop/packages/swapper-nodechain-client Docs: https://hippocampus.gitbook.io/swapper-1/repositorio-monorepo/packages/swapper-nodechain-client

Perfect, i could do that tomorrow

[0xp3gasus]

Please, review comments. Thanks for your contribution 💪🏽

[0xp3gasus]

Thanks for your contribution.