-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
60 isolate connector #92
60 isolate connector #92
Conversation
|
||
def start(self): | ||
|
||
# TODO: Check this is working properly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO here. Is this checked?
|
||
async def stop(self): | ||
|
||
# TODO: Check this is working properly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO here. Is this checked?
reqParsed[rpcutils.ID] if reqParsed is not None else rpcutils.UNKNOWN_RPC_REQUEST_ID, | ||
e.jsonEncode() | ||
) | ||
# from utils import utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented line should be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package utils is going to be mandatory once the script is refactored
This PR is huge, @hippocampusSwapper and @bridgedragon should review this PR |
Description
Connector can be isolated from blockchain nodes. It supports multiple tokens at the same time in differents networks. With the Admin package created, it is posible to add, update and remove tokens in differents networks. The rest of the functionality of the connector is the same.
Endpoint paths have been replace from
/rpc
and/ws
to{coin}/{network}/rpc
and/{coin}/network}/ws
Fixes #60
Dependencies (if any)
None
Type of change
How Has This Been Tested?
Adding ETH Token in regtest network to connector
Request
Response
Getting ETH config
Request
Response
Removing ETH token in regtest network from connector
Request
Response
Making RPC request to ETH token in regtest network when it is not added to connector
Request
Response
Making RPC request to ETH token in regtest network when it is added to connector
Request
Response
Wesockets subscribe to New Blocks Topic in ETH token in regtest mode
Endpoint: ws://localhost:80/eth/regtest/ws
Request
Response
Test Configuration:
sw_vers
): macOS 12.0.1Good practices to consider