Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add videodetailsasset endpoint #325

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

OnerInce
Copy link
Contributor

Closes #314

@rsforbes
Copy link
Collaborator

@OnerInce - Apologies for the delay. Will get this reviewed over the weekend.

@swar
Copy link
Owner

swar commented Mar 20, 2023

This looks good to me! I'll wait for Randy to take a glance as well.

@rsforbes
Copy link
Collaborator

rsforbes commented Mar 23, 2023

Uh... just saw we were discussing all of this on #292. LOL!!!


@swar / @OnerInce - I'm going to pull this in. It's a good call.

At the same time, we need to start figuring out how to handle data that does not have the traditional "header" element within the other stats endpoint calls. I've seen a few calls where the data from stats.nba.com is not traditionally structured.

# EXAMPLES

# playbyplay (traditional)
"resultSets": [
    {
        "name": "PlayByPlay",
        "headers": [
            "GAME_ID",
            "EVENTNUM", ...

# videodetailassett <-- This PR
"resultSets": {
    "Meta": {
      "videoUrls": [
        {
          "uuid": "436d96fe-2f19-3999-6550-7fd0ae4dd23a",
          "sdur": 7600,
          "surl": "https://videos.nba.c...

#  scoreboardv3 <-- one I've been looking; also from stats.nba.com, but actually pulled from nba.cloud...
{
    "meta": {
        "version": 1,
        "request": "http://nba.cloud/league/00/2022/10/31/scoreboard?Format=json",
        "time": "2023-03-23T16:31:57.3157Z"
    },
    "scoreboard": {
        "gameDate": "2022-10-31",
        "leagueId": "00",
        "leagueName": "National Basketball Association",
        "games": [
            {
                "gameId": "0022200096", ...

@rsforbes rsforbes merged commit 03525e7 into swar:master Mar 23, 2023
rsforbes added a commit to rsforbes/nba_api that referenced this pull request Mar 23, 2023
rsforbes added a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VideoEventDetailAsset endpoint
3 participants