Added PlayByPlay Regex for Ejections. Restructured PlayByPlay Tests. #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grouped tests for PlayByPlay into folder. Separated out data from tests to be more inclusive of disparate data that is identified throughout the PlayByPlay feed.
TestData is structured into a
collections.defaultdict
. This allows the data to be looked up by a key (e.g.FieldGoalMade
). The values are stored as ak:v
pair that work against thedescription
key/value which contains the actual play as presented by the NBA. The other key\values correspond to the regex capture groups.Overall, this will make testing much easier as new data is found and regex is modified to accommodate.
EXAMPLES OF DIFFERENT DATA: