Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to manage "vendored" boolexpr dependency? #934

Closed
kostmo opened this issue Dec 28, 2022 · 2 comments · Fixed by #1188
Closed

How to manage "vendored" boolexpr dependency? #934

kostmo opened this issue Dec 28, 2022 · 2 comments · Fixed by #1188
Labels
Z-Meta This issue is about other Swarm issues or infrastructure.

Comments

@kostmo
Copy link
Member

kostmo commented Dec 28, 2022

The boolexpr package needs this PR to support modern GHC. I was able to include the "boolexpr" package as a "vendored dependency" by copying in the code and adding it as a local package in stack.yaml. This works with stack build. However, the CI build doesn't seem to respect this local dependency.


UPDATE: The PR boolexpr/boolexpr#2 has been merged - thanks @np and @kostmo!

@kostmo kostmo added the Z-Meta This issue is about other Swarm issues or infrastructure. label Dec 28, 2022
@xsebek
Copy link
Member

xsebek commented Dec 31, 2022

We used to do this in cabal-extra (I think was the name) with other libraries.

The problem is that this will not work for release. The built binary will have the released version of the dependency.

@xsebek
Copy link
Member

xsebek commented Feb 20, 2023

@kostmo I could not find your comment about whether you reached out to the boolexpr author via mail in #927.

I reached out to the author on the Keybase messaging platform and will update you with the results. 😉

@xsebek xsebek changed the title How to manage "vendored" dependencies? How to manage "vendored" boolexpr dependency? Feb 20, 2023
@mergify mergify bot closed this as completed in #1188 Apr 1, 2023
mergify bot pushed a commit that referenced this issue Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Meta This issue is about other Swarm issues or infrastructure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants