Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use internal attribute type in Display #1100

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Use internal attribute type in Display #1100

merged 1 commit into from
Feb 10, 2023

Conversation

xsebek
Copy link
Member

@xsebek xsebek commented Feb 9, 2023

This avoids using Brick.AttrName and we can remove the -fno-warn-orphans from Attr.hs.

As a bonus, we can now specify a terrain attribute (terrain_stone) in a scenario along with the default attribute.

@xsebek
Use internal attribute type in Display
fcddd46 
This avoids using `Brick.AttrName` and we can remove
the `-fno-warn-orphans` from `Attr.hs`.
@xsebek xsebek requested review from kostmo and byorgey February 9, 2023 17:56
byorgey
byorgey approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xsebek xsebek added the merge me Trigger the merge process of the Pull request. label Feb 10, 2023
@mergify mergify bot merged commit 04800f0 into main Feb 10, 2023
@mergify mergify bot deleted the attr-split branch February 10, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

@kostmo kostmo kostmo approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xsebek @kostmo @byorgey