Segfault when enabling screen with changed modes #4730
Comments
emersion
added a commit
to emersion/wlroots
that referenced
this issue
Dec 5, 2019
When surf->gbm was previously set, we destroy it without setting it to NULL. Later on, we only create the GBM surface if surf->gbm is NULL. This result in a use-after-free when we start using surf->gbm. Closes: swaywm#1868 Closes: swaywm#1874 Closes: swaywm/sway#4785 Closes: swaywm/sway#4717 Closes: swaywm/sway#4730 Fixes: 2bdd1d0 ("backend/drm: use modifiers for our GBM buffers")
ddevault
pushed a commit
to swaywm/wlroots
that referenced
this issue
Dec 5, 2019
When surf->gbm was previously set, we destroy it without setting it to NULL. Later on, we only create the GBM surface if surf->gbm is NULL. This result in a use-after-free when we start using surf->gbm. Closes: #1868 Closes: #1874 Closes: swaywm/sway#4785 Closes: swaywm/sway#4717 Closes: swaywm/sway#4730 Fixes: 2bdd1d0 ("backend/drm: use modifiers for our GBM buffers")
|
This issue was unfortunately not fixed. Following backtrace is from |
|
This one is a dup of #4717 |
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this issue
Dec 19, 2019
When surf->gbm was previously set, we destroy it without setting it to NULL. Later on, we only create the GBM surface if surf->gbm is NULL. This result in a use-after-free when we start using surf->gbm. Closes: swaywm#1868 Closes: swaywm#1874 Closes: swaywm/sway#4785 Closes: swaywm/sway#4717 Closes: swaywm/sway#4730 Fixes: 2bdd1d0 ("backend/drm: use modifiers for our GBM buffers")
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this issue
Dec 19, 2019
When surf->gbm was previously set, we destroy it without setting it to NULL. Later on, we only create the GBM surface if surf->gbm is NULL. This result in a use-after-free when we start using surf->gbm. Closes: swaywm#1868 Closes: swaywm#1874 Closes: swaywm/sway#4785 Closes: swaywm/sway#4717 Closes: swaywm/sway#4730 Fixes: 2bdd1d0 ("backend/drm: use modifiers for our GBM buffers")
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this issue
Dec 19, 2019
When surf->gbm was previously set, we destroy it without setting it to NULL. Later on, we only create the GBM surface if surf->gbm is NULL. This result in a use-after-free when we start using surf->gbm. Closes: swaywm#1868 Closes: swaywm#1874 Closes: swaywm/sway#4785 Closes: swaywm/sway#4717 Closes: swaywm/sway#4730 Fixes: 2bdd1d0 ("backend/drm: use modifiers for our GBM buffers")
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this issue
Dec 19, 2019
When surf->gbm was previously set, we destroy it without setting it to NULL. Later on, we only create the GBM surface if surf->gbm is NULL. This result in a use-after-free when we start using surf->gbm. Closes: swaywm#1868 Closes: swaywm#1874 Closes: swaywm/sway#4785 Closes: swaywm/sway#4717 Closes: swaywm/sway#4730 Fixes: 2bdd1d0 ("backend/drm: use modifiers for our GBM buffers")
aiqs4
pushed a commit
to aiqs4/wlroots
that referenced
this issue
Dec 19, 2019
When surf->gbm was previously set, we destroy it without setting it to NULL. Later on, we only create the GBM surface if surf->gbm is NULL. This result in a use-after-free when we start using surf->gbm. Closes: swaywm#1868 Closes: swaywm#1874 Closes: swaywm/sway#4785 Closes: swaywm/sway#4717 Closes: swaywm/sway#4730 Fixes: 2bdd1d0 ("backend/drm: use modifiers for our GBM buffers")
|
Did you find any solution @kennylevinsen ? I still have this issue randomly occurring during normal usage (not only when changing outputs). |
|
@Jasmich Open a new issue with logs and stacktrace. Crashes occurring during normal use is unlikely to be related to this issue. Also, compare segfaults from output changes and normal usage, just in case they are in fact different crashes. |
filips
pushed a commit
to filips/wlroots
that referenced
this issue
Mar 15, 2020
When surf->gbm was previously set, we destroy it without setting it to NULL. Later on, we only create the GBM surface if surf->gbm is NULL. This result in a use-after-free when we start using surf->gbm. Closes: swaywm#1868 Closes: swaywm#1874 Closes: swaywm/sway#4785 Closes: swaywm/sway#4717 Closes: swaywm/sway#4730 Fixes: 2bdd1d0 ("backend/drm: use modifiers for our GBM buffers")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
After resuming from sleep and reenabling external displays, sway segfaults. This has happened twice with the same trace.
This may be connected to one screen of mine, which sometimes after waking registers with fewer modes than normal (only up to FHD rather than 4k). That this has occurred can be seen in the debug log.
The debug log shows an attempt to set "12336x0@600 mHz", which seems quite bogus.
Sway version
sway version 1.2-f576bcdb (Nov 5 2019, branch 'master')
Debug Log
Stack trace
The text was updated successfully, but these errors were encountered: