Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide_cursor stops countdown after left clicking once (but not moving the cursor) #5679

Closed
antisocrates opened this issue Sep 14, 2020 · 8 comments · Fixed by #5681 or #5682
Closed

hide_cursor stops countdown after left clicking once (but not moving the cursor) #5679

antisocrates opened this issue Sep 14, 2020 · 8 comments · Fixed by #5681 or #5682
Labels
bug Not working as intended input/pointer

Comments

@antisocrates
Copy link

antisocrates commented Sep 14, 2020 •
edited
Loading

  • Sway Version:
    sway version v1.5

  • Debug Log:
    sway.log

  • Configuration File:
    config

  • Description:
    Using seat * hide_cursor 3000 in sway config to hide the mouse cursor after 3 seconds of inactivity.
    The countdown (towards timeout to hide the cursor) stops after clicking anywhere indefinately (until the cursor moves again)

    Steps to reproduce:

  1. Left click anywhere

  2. Dont move the cursor (stay on the same spot you clicked, otherwise countdown resets and hides as normal)

    Here is a 60second demonstration of the issue i have uploaded:
    Video Demonstration

Clarification:
Clicking will stop the countdown, showing the cursor, but won't restart it so the cursor will remain visible indefinitely until moved.
@antisocrates antisocrates added the bug Not working as intended label Sep 14, 2020
@justinlovinger
Copy link

Clicking is mouse activity. I would expect the countdown to reset after any mouse activity, not just movement.

Emantor added a commit to Emantor/sway that referenced this issue Sep 14, 2020
@Emantor
input/cursor: reset event source after unhide
4ae89ae 
Reset the event source after unhiding the cursor, to ensure that the
timeout starts after showing the cursor. Also remove the open coded
variant in seat_consider_warp_to_focus().

Fixes swaywm#5679
@Emantor Emantor mentioned this issue Sep 14, 2020
Merged
@Emantor
Copy link
Contributor

Emantor commented Sep 14, 2020

Please test #5681.

@fluix-dev
Copy link
Contributor

Clicking is mouse activity. I would expect the countdown to reset after any mouse activity, not just movement.

To clarify, because I got confused as well, the issue seems to be that clicking will stop the countdown, showing the cursor, but won't restart it so the cursor will remain visible indefinitely until moved.

Emantor added a commit to Emantor/sway that referenced this issue Sep 14, 2020
@Emantor
input/cursor: reset event source after unhide
91cf674 
Reset the event source after unhiding the cursor, to ensure that the
timeout starts after showing the cursor. Also remove the open coded
variant in seat_consider_warp_to_focus().

Fixes swaywm#5679
@antisocrates
Copy link
Author

antisocrates commented Sep 14, 2020 •
edited
Loading

To clarify, because I got confused as well, the issue seems to be that clicking will stop the countdown, showing the cursor, but won't restart it so the cursor will remain visible indefinitely until moved.

Yes thats exactly what happens. I added this clarification to the bug report.

@antisocrates
Copy link
Author

Please test #5681.

I am building sway from git master branch with your commit, but the build fails (for unrelated reason as far as i understand)

ninja

meson

@fluix-dev
Copy link
Contributor

@antisocrates update wlroots.

Xyene pushed a commit that referenced this issue Sep 14, 2020
@Emantor @Xyene
input/cursor: reset event source after unhide
afa890e 
Reset the event source after unhiding the cursor, to ensure that the
timeout starts after showing the cursor. Also remove the open coded
variant in seat_consider_warp_to_focus().

Fixes #5679
Xyene added a commit to Xyene/sway that referenced this issue Sep 14, 2020
@Xyene
input/pointer: update cursor activity after updating button counts
9371c59 
Otherwise, Sway will not re-hide a cursor after the last button has been
released.

Needed alongside afa890e to fix swaywm#5679.
@Xyene Xyene mentioned this issue Sep 14, 2020
Merged
@Xyene
Copy link
Member

Xyene commented Sep 14, 2020

Not quite resolved yet.

@Xyene Xyene reopened this Sep 14, 2020
RedSoxFan pushed a commit that referenced this issue Sep 15, 2020
@Xyene @RedSoxFan
input/pointer: update cursor activity after updating button counts
2efecc1 
Otherwise, Sway will not re-hide a cursor after the last button has been
released.

Needed alongside afa890e to fix #5679.
@antisocrates
Copy link
Author

antisocrates commented Sep 15, 2020 •
edited
Loading

The original issue is fixed.

One minor observation, comparing the hide_cursor behavior, with the behavior of unclutter on i3/xorg:

When you first login on i3/xorg, unclutter starts the countdown immediately and hides the cursor after 3 seconds for example.

In contrast, when you first login on sway, hide_cursor does not start the countdown and the cursor remains visible indefinetely until the first activity. (until you click or move the cursor for the first time)

I am not sure if this is intended behavior or a bug, so i also report this: #5684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Not working as intended input/pointer
Milestone
No milestone
5 participants
@Emantor @Xyene @justinlovinger @fluix-dev @antisocrates