Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointer can leave fullscreen container off bounded edge #5792

Closed
Xyene opened this issue Nov 4, 2020 · 0 comments · Fixed by #5793
Closed

Pointer can leave fullscreen container off bounded edge #5792

Xyene opened this issue Nov 4, 2020 · 0 comments · Fixed by #5793
Labels
bug Not working as intended input/pointer

Comments

@Xyene
Copy link
Member

Xyene commented Nov 4, 2020

This has been around for a while, and is still present in master.

If an app is fullscreened (from WM), and the mouse is moved all the way to the top of its output (bounded at the top -- no second output is present above it) and clicked, sometimes the application will receive a pointer leave event.

[2641171.164] wl_pointer@3.motion(286023954, 230.992188, 0.000000)
[2641171.179] wl_pointer@3.frame()
[2641174.174] wl_pointer@3.frame()
[2641176.178] wl_pointer@3.motion(286023959, 231.402344, 0.000000)
[2641176.190] wl_pointer@3.frame()
[2641180.287] wl_pointer@3.frame()
[2641185.173] wl_pointer@3.frame()
[2641193.203] wl_pointer@3.frame() <----------- empty frames since mouse is totally at the top of the output
[2641243.306] wl_pointer@3.frame()
[2641478.382] wl_pointer@3.motion(286024261, 231.269531, 0.000000)
[2641478.413] wl_pointer@3.frame()
[2641484.244] wl_pointer@3.frame()
[2641497.258] wl_pointer@3.leave(106841, wl_surface@96)   <---------------------- this was a left button click
[2641497.283]  -> wl_pointer@3.set_cursor(106813, wl_surface@17, 3, 3)
[2641497.295]  -> wl_surface@17.attach(wl_buffer@52, 0, 0)
[2641497.301]  -> wl_surface@17.set_buffer_scale(2)
[2641497.305]  -> wl_surface@17.damage(0, 0, 24, 24)
[2641497.312]  -> wl_surface@17.commit()
[2641497.319] wl_pointer@3.frame()
[2641497.342] xdg_toplevel@95.configure(2560, 1440, array)
[2641497.349] xdg_surface@100.configure(106839)
[2641497.360]  -> xdg_surface@100.ack_configure(106839)
[2641497.365] xdg_toplevel@46.configure(1257, 450, array)
[2641497.370] xdg_surface@45.configure(106840)
[2641497.375]  -> xdg_surface@45.ack_configure(106840)
[2641509.548] wl_buffer@137.release()

This confuses the application -- Firefox, for instance, will refuse to take mouse input again until it is unfullscreened.

Whether this happens or not seems to be dependent on the dimensions and position of the container prior to being fullscreened. The below layout (H[kitty V[kitty firefox]], no extra resizing) reliably reproduces the issue after resizing Firefox:

image
@Xyene Xyene added bug Not working as intended input/pointer labels Nov 4, 2020
@Xyene Xyene changed the title Pointer can leave fullscreen floating container off bounded edge Pointer can leave fullscreen container off bounded edge Nov 4, 2020
Xyene added a commit to Xyene/sway that referenced this issue Nov 4, 2020
@Xyene
input/seatop_default: consider fullscreen views to have no edges
7c535db 
Previously, `find_edge` on a single fullscreen view would occasionally
return an edge rather than `WLR_EDGE_NONE`. This would trigger entry
into `seatop_resize_tiling`, which doesn't have meaning for a fullscreen
view.

The result was that the fullscreen container hitbox was considered to be
that of where it'd be if it were tiling, so most clicks would not go
through.

Fixes swaywm#5792.
@Xyene Xyene mentioned this issue Nov 4, 2020
Merged
emersion pushed a commit that referenced this issue Nov 5, 2020
@Xyene @emersion
input/seatop_default: consider fullscreen views to have no edges
0df5753 
Previously, `find_edge` on a single fullscreen view would occasionally
return an edge rather than `WLR_EDGE_NONE`. This would trigger entry
into `seatop_resize_tiling`, which doesn't have meaning for a fullscreen
view.

The result was that the fullscreen container hitbox was considered to be
that of where it'd be if it were tiling, so most clicks would not go
through.

Fixes #5792.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Not working as intended input/pointer
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

input/seatop_default: consider fullscreen views to have no edges Xyene/sway
1 participant
@Xyene