Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite key repeat after killing fcitx #6254

Open
Michael-Jing opened this issue May 5, 2021 · 3 comments
Open

Infinite key repeat after killing fcitx #6254

Michael-Jing opened this issue May 5, 2021 · 3 comments
Labels
bug Not working as intended

Comments

@Michael-Jing
Copy link

Michael-Jing commented May 5, 2021 •
edited
Loading

  • Sway Version:
    1.6

  • Debug Log:
    log

  • Configuration File:
    default

  • Description:

    1. Launch sway using default config from tty
    2. Use Mod + Enter shortcuts to open a terminal
    3. type fcitx5 -r into the terminal and hit Enter
    4. Once fcitx5 is started, press Ctrl + c to terminate it
    5. you will see c (ie. the last key pressed by user) is sending to terminal window automatically
    6. I encountered this issue after a recent manjaro upgrade. it happens very frequently, start and then terminate fcitx5 is a quick way I found to reproduce the issue
@Michael-Jing Michael-Jing added the bug Not working as intended label May 5, 2021
@emersion emersion changed the title Sway sends keystrokes automatically Infinite key repeat after killing fcitx May 5, 2021
@emersion
Copy link
Member

emersion commented May 5, 2021

Also reproducible with wlhangul.

@emersion
Copy link
Member

emersion commented May 5, 2021

I think this is meant to fix it: swaywm/wlroots#2697

yuja added a commit to yuja/wlroots that referenced this issue May 7, 2021
@yuja
virtual_keyboard: Emulate key release events on destroy
ad386c6 
According to libinput, release events are generated when device is unplugged,
and libinput copies this behavior for device removal. Let's do the same for
our virtual keyboard.

https://github.com/wayland-project/libinput/commit/8f846a41fa0566fbd72ece676656e20e56ce43e6

This is another attempt to fix swaywm#2034 and the following sway issue:

swaywm/sway#6254

Note that we have other key repeating issues in sway, which aren't addressed
by this patch. Since the virtual keyboard itself isn't destroyed when the
keyboard grab is destroyed, we'll probably need some trick to reset the state
of the corresponding virtual keyboard when the grab is released.

swaywm/sway#6095
swaywm/sway#6193
@yuja yuja mentioned this issue May 7, 2021
Merged
emersion pushed a commit to swaywm/wlroots that referenced this issue May 7, 2021
@yuja @emersion
virtual_keyboard: Emulate key release events on destroy
8008d21 
According to libinput, release events are generated when device is unplugged,
and libinput copies this behavior for device removal. Let's do the same for
our virtual keyboard.

https://github.com/wayland-project/libinput/commit/8f846a41fa0566fbd72ece676656e20e56ce43e6

This is another attempt to fix #2034 and the following sway issue:

swaywm/sway#6254

Note that we have other key repeating issues in sway, which aren't addressed
by this patch. Since the virtual keyboard itself isn't destroyed when the
keyboard grab is destroyed, we'll probably need some trick to reset the state
of the corresponding virtual keyboard when the grab is released.

swaywm/sway#6095
swaywm/sway#6193
@Michael-Jing
Copy link
Author

Michael-Jing commented May 15, 2021 •
edited
Loading

I compiled and installed sway yesterday and it seems that the problem remains even through I can not reproduce it with killing fcitx5 anymore. It seems that a lot of times the issue is triggered by using wofi

Sway Version:
sway version 1.6-31b4b96e (May 14 2021, branch 'master')

Debug Log:
log

Configuration File:
config
diff from the default:
I use Mod1
I use wofi
I use dvorak
I swap escape and capslock
I start fcitx5 and the end the config file

Description:

Launch sway using the config from tty, start to play with it, the issue will happen within several minutes, usually it will be triggered by trying to launch something using wofi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Not working as intended
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emersion @Michael-Jing