Implement Tray Icons #1234

4e554c4c · 2017-06-08T00:18:19Z

There are still issues with this commit, mostly in dealing with xembedsniproxy. It creates dummy windows for placing XEmbed items which sway renders even though it shouldn't. Also xembedsniproxy is a super buggy program, so there still may be undiscovered problems with it.

This commit implements the StatusNotifierItem protocol, and enables
swaybar to show tray icons. It also uses xembedsniproxy in order to
communicate with xembed applications.
The tray is completely optional, and can be disabled on compile time
with the enable-tray option. Or on runtime with the bar config option
tray_output none.

Overview of changes:
In swaybar very little is changed outside the tray subfolder except
that all events are now polled in event_loop.c, this creates no
functional difference.

Six bar configuration options were added, these are detailed in
sway-bar(5)

The tray subfolder is where all protocol implementation takes place and
is organised as follows:

tray/sni_watcher.c:
This file contains the StatusNotifierWatcher. It keeps track of
items and hosts and reports when they come or go.
tray/tray.c
This file contains the StatusNotifierHost. It keeps track of
sway's version of the items and represents the tray itself.
tray/sni.c
This file contains the StatusNotifierItem struct and all
communication with individual items.
tray/icon.c
This file implements the icon theme protocol. It allows for
finding icons by name, rather than by pixmap.
tray/dbus.c
This file allows for asynchronous DBus communication.

Note: Package maintainers sholud add xembedsniproxy and libdbus as optional dependencies of sway.

See #986 #343

This commit implements the StatusNotifierItem protocol, and enables swaybar to show tray icons. It also uses `xembedsniproxy` in order to communicate with xembed applications. The tray is completely optional, and can be disabled on compile time with the `enable-tray` option. Or on runtime with the bar config option `tray_output none`. Overview of changes: In swaybar very little is changed outside the tray subfolder except that all events are now polled in `event_loop.c`, this creates no functional difference. Six bar configuration options were added, these are detailed in sway-bar(5) The tray subfolder is where all protocol implementation takes place and is organised as follows: tray/sni_watcher.c: This file contains the StatusNotifierWatcher. It keeps track of items and hosts and reports when they come or go. tray/tray.c This file contains the StatusNotifierHost. It keeps track of sway's version of the items and represents the tray itself. tray/sni.c This file contains the StatusNotifierItem struct and all communication with individual items. tray/icon.c This file implements the icon theme protocol. It allows for finding icons by name, rather than by pixmap. tray/dbus.c This file allows for asynchronous DBus communication. See #986 #343

ddevault · 2017-06-08T01:38:01Z

One commit ;_;

ddevault · 2017-06-08T02:09:58Z

swaybar/bar.c

+		}
+		tray_width -= icon_width;
+	}
+#endif


Can you move this into another file?

ddevault · 2017-06-08T02:10:17Z

swaybar/bar.c

+		_exit(EXIT_FAILURE);
+	}
+}
+#endif


Consider moving this as well, just have a tray upkeep function that checks this and refires it if not running

ddevault · 2017-06-08T02:15:03Z

swaybar/bar.c

+		/* Start xembedsniproxy */
+		spawn_xembed_sni_proxy();
+	}
+#endif


This one too, just make it a simple

#ifdef ENABLE_TRAY init_tray(); #endif

Then make init_tray do all this work. Try to limit the tray code in this file to simple calls to another function.

ddevault · 2017-06-08T02:16:41Z

swaybar/render.c

+		tray_width -= tray_padding;
+	}
+
+no_tray:


Ditto here. Move it all into a separate function in another file.

ddevault · 2017-06-08T02:48:05Z

Problems I noticed while testing:

SNI works quite well, nice job. The exception is that I can't seem to select context menu items that are occluded by other windows. Does the compositor need to do something special to let them keep focus? (i.e. open konversation's context menu and try to use any option that is displayed on top of another window, such as the konversation main window). Clicking outside of the context menu also doesn't seem to close it, and should. Making sure the context menu windows are getting focus should fix both of these issues.
xembed doesn't work at all for me. The issues with it need to be ironed out or it needs to be removed before I'm comfortable merging this.

ddevault · 2017-06-08T02:48:26Z

I also pushed a commit fixing up the cairo blending operator so that partially transparent icons wouldn't overwrite the background.

Remove tray code from bar.c and render.c

The unique name was not copied out of the wire marshalled DBus message data so `sni_uniq_cmp` would always match against junk data.

ddevault · 2017-06-13T16:42:26Z

Status?

4e554c4c · 2017-06-13T19:35:21Z

Still working on getting tray windows working, pretty much everything else is in order.

Xembed support is premature in sway and should be postponed. This commit only removes swaybar starting xembedsniproxy, if users would like, they can still start xembedsniproxy manually, however there will be no official support.

ddevault · 2017-06-13T22:48:59Z

Should I hold off on rc1 for this?

4e554c4c · 2017-06-14T02:38:26Z

I'd say not, unless you really want it there. I can't work on this 100% right now, so it might be good to delay things. Also I'm not even sure if it'd be good to release sni support without xembed included. People who don't know the difference will probably file reports.

ddevault · 2017-06-14T04:48:35Z

I'm okay with shipping SNI support alone, we already get plenty of stupid support requets and I doubt this will add much. I'll have a look at this in the morning and see if I can clean it up and still feel good about it.

And probably some other stuff too

ddevault · 2017-06-14T22:15:19Z

Spent some time poking on this. Results: focus is working good enough for now. Also I figured out what was wrong with the firefox address bar dropdown and fixed that. Going to include this in the next release and maybe iterate on it a bit during rc's to fix the edge cases.

4e554c4c · 2017-06-15T00:46:38Z

Thanks!

4e554c4c · 2017-06-15T00:50:56Z

I'll continue work on xembed, hopefully we can have that in the next release.

nemanjan00 · 2017-11-12T22:31:44Z

Any progress?

ddevault · 2017-11-12T22:52:19Z

Yep.

ddevault reviewed Jun 8, 2017

View reviewed changes

swaybar/bar.c Outdated

}

tray_width -= icon_width;

}

#endif

Copy link

Contributor

ddevault Jun 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this into another file?

ddevault reviewed Jun 8, 2017

View reviewed changes

Fix cairo blending on tray icons

790887c

Calvin Lee added 2 commits June 7, 2017 21:32

Reorganize Tray Code

1451ee8

Remove tray code from bar.c and render.c

Fix Catching NewIcon Signal

0a71aa6

The unique name was not copied out of the wire marshalled DBus message data so `sni_uniq_cmp` would always match against junk data.

Remove Xembed Support

33fdae2

Xembed support is premature in sway and should be postponed. This commit only removes swaybar starting xembedsniproxy, if users would like, they can still start xembedsniproxy manually, however there will be no official support.

ddevault added 3 commits June 14, 2017 18:09

Fix Firefox address bar thing

d158e18

And probably some other stuff too

Force focus on unmanaged views during pointer test

76fcfa1

Merge branch 'master' into tray

0fc9628

ddevault merged commit eb6e38c into swaywm:master Jun 14, 2017

ddevault mentioned this pull request Jun 15, 2017

0.14 #1237

Closed

kellpossible mentioned this pull request Aug 21, 2017

i3bar compatability #343

Closed

19 tasks

orestisfl mentioned this pull request Apr 3, 2018

Adopt the StatusNotifierItem specification i3/i3#2088

Closed

4e554c4c mentioned this pull request Nov 26, 2023

XembedSniProxy displaying a small black square #7130

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Tray Icons #1234

Implement Tray Icons #1234

4e554c4c commented Jun 8, 2017 •

edited

Loading

ddevault commented Jun 8, 2017

ddevault Jun 8, 2017

ddevault Jun 8, 2017

ddevault Jun 8, 2017

ddevault Jun 8, 2017

ddevault commented Jun 8, 2017

ddevault commented Jun 8, 2017 •

edited

Loading

ddevault commented Jun 13, 2017

4e554c4c commented Jun 13, 2017

ddevault commented Jun 13, 2017

4e554c4c commented Jun 14, 2017 •

edited

Loading

ddevault commented Jun 14, 2017

ddevault commented Jun 14, 2017 •

edited

Loading

4e554c4c commented Jun 15, 2017

4e554c4c commented Jun 15, 2017

nemanjan00 commented Nov 12, 2017

ddevault commented Nov 12, 2017

Implement Tray Icons #1234

Implement Tray Icons #1234

Conversation

4e554c4c commented Jun 8, 2017 • edited Loading

ddevault commented Jun 8, 2017

ddevault Jun 8, 2017

Choose a reason for hiding this comment

ddevault Jun 8, 2017

Choose a reason for hiding this comment

ddevault Jun 8, 2017

Choose a reason for hiding this comment

ddevault Jun 8, 2017

Choose a reason for hiding this comment

ddevault commented Jun 8, 2017

ddevault commented Jun 8, 2017 • edited Loading

ddevault commented Jun 13, 2017

4e554c4c commented Jun 13, 2017

ddevault commented Jun 13, 2017

4e554c4c commented Jun 14, 2017 • edited Loading

ddevault commented Jun 14, 2017

ddevault commented Jun 14, 2017 • edited Loading

4e554c4c commented Jun 15, 2017

4e554c4c commented Jun 15, 2017

nemanjan00 commented Nov 12, 2017

ddevault commented Nov 12, 2017

4e554c4c commented Jun 8, 2017 •

edited

Loading

ddevault commented Jun 8, 2017 •

edited

Loading

4e554c4c commented Jun 14, 2017 •

edited

Loading

ddevault commented Jun 14, 2017 •

edited

Loading