Really fix floating window border resize problems #5299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this also fixes the issue I had. |
|
Let me know when this is ready for review. |
|
Thanks for the reminder. Ready for review now. |
emersion
reviewed
May 10, 2020
| // Determine new width/height, and accommodate for floating min/max values | ||
| double width = e->ref_width + grow_width; | ||
| double height = e->ref_height + grow_height; | ||
| int min_width, max_width, min_height, max_height; | ||
| floating_calculate_constraints(&min_width, &max_width, | ||
| &min_height, &max_height); | ||
| width = fmax(min_width, fmin(width, max_width)); | ||
| height = fmax(min_height, fmin(height, max_height)); | ||
| width = fmax(min_width + border_width, fmin(width, max_width)); |
There was a problem hiding this comment.
We should probably take border_width into account for the max too? Something like max_width - border_width? We should also be careful that the result is > 0.
There was a problem hiding this comment.
Let's merge this PR as-is. I've created a follow-up issue: #5337
This was referenced May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same problem, different approach.
Fixes: #5250
I've done testing of all combinations of settings and runtime border changes with resize I could come up with. So far I'm unable to see it brake. More testing is welcome.
@David96 : please test this instead #5292, it should resolve your problems.