color management #5586
Closed
color management #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If moving e.g. `T[app app]` into a new workspace with `workspace_layout tabbed`, then post-move the tree in that workspace will be `T[T[app app]]`. This still happens with horizontal or vertical workspace layout, but is less visible since those containers have no decorations. Fixes swaywm#5426. (cherry picked from commit 92891fb)
sway_input_method_relay_set_focus was called before sway_input_method_relay_init. Closes: swaywm#5503 (cherry picked from commit 1bfbf26)
This causes a NULL pointer dereference. (cherry picked from commit dfccd2a)
Avoids having applications connect to a leftover DISPLAY when Xwayland fails to initialize. (cherry picked from commit eb4fa18)
xdg-shell doesn't allow clients to set the title to NULL, so we shouldn't need to call wlr_foreign_toplevel_handle_v1_set_title with an empty string to reset the old one. Closes: swaywm#5488 (cherry picked from commit b5a35c4)
(cherry picked from commit 17ff13f)
Fixes swaywm#5157. (cherry picked from commit b4a75a1)
(cherry picked from commit 1d14923)
(cherry picked from commit ea3ba20)
Previously, we called output_disable prior to wlr_output_commit. This mutates Sway's output state before the output commit actually succeeds. This results in Sway's state getting out-of-sync with wlroots'. An alternative fix [1] was to revert the changes made by output_disable in case of failure. This is a little complicated. Instead, this patch makes it so Sway's internal state is never changed before a successful wlr_output commit. We had two output flags: enabled and configured. However enabled was set prior to the output becoming enabled, and was used to prevent the output event handlers (specifically, the mode handler) from calling apply_output_config again (infinite loop). Rename enabled to enabling and use it exclusively for this purpose. Rename configure to enabled, because that's what it really means. [1]: swaywm#5521 Closes: swaywm#5483 (cherry picked from commit 5432f00)
**Problem** When I rename the workspace to something like "1:web", `$mod+1` does not move to the "1:web" with the default config. This breaks the expectation of i3 users. **Cause** The default Sway binding for `$mod+1` does not have the number keyword: ``` bindsym $mod+1 workspace 1 ``` Instead, the default Sway binding for `$mod+1` is ``` bindsym Mod1+1 workspace number $ws1 ``` i3/i3@e6662df is the corresponding commit from i3. (cherry picked from commit 585236f)
(cherry picked from commit 10ec97c)
References: swaywm#5483 (cherry picked from commit 9bb7028)
(cherry picked from commit 4dd46f0)
(cherry picked from commit acbe902)
In case when slurp is used to select part of screen or a window, if user aborts the selection, grimshot will capture the whole screen instead of exiting. This is fixed with check for empty variable. (cherry picked from commit c65cd1c)
On warping to a cursor hint, update the pointer position we track as well, so that on the next pointer rebase we don't send an unexpected synthetic motion event to clients. Fixes swaywm#5405. (cherry picked from commit 6b9a9b6)
(cherry picked from commit 9f944ff)
(cherry picked from commit 5ae4f65)
sway 1.5.1
This is a bugfix release which adds support for wlroots 0.12.0.
Simon Ser (2):
build: bump wlroots dependency to 0.12.0
build: bump version to 1.5.1
(cherry picked from commit 1d62d6b)
This is now a mandatory dependency for wlroots. (cherry picked from commit 276a37a)
(cherry picked from commit 62fbf33)
|
output * { Sorry for the lame question, but how can I use a custom path? |
|
When will it be merged? |
|
support for color management has been merged in #7681 , so I assume this can be closed? |
|
Indeed, this has been superseded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic color management to sway. It's a companion to swaywm/wlroots#2353.
Basically it just adds two options which control the ICC profile assigned to views and outputs, which are passed into wlroots where the conversion is done:
See also: #1486.