Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands: Remove unused code after 1d3681f52135 #6566

Merged
merged 1 commit into from
Oct 1, 2021
Merged

commands: Remove unused code after 1d3681f52135 #6566

merged 1 commit into from
Oct 1, 2021

Conversation

ekhramtsov
Copy link
Contributor

@ekhramtsov ekhramtsov commented Oct 1, 2021

Clang 13 reports:

../sway/commands.c:470:23: error: variable 'context' set but not used
[-Werror,-Wunused-but-set-variable]
enum command_context context = 0;
^
Last use of was removed in commit 1d3681f.

Downstream PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258813

--
I removed lines 470-495 and related because I couldn't find code that would pass "ipc"
and "binding" so they end up in argv[i]. This might be wrong.

Clang 13 reports:

../sway/commands.c:470:23: error: variable 'context' set but not used
[-Werror,-Wunused-but-set-variable]
        enum command_context context = 0;
                             ^
Last use of was removed in commit 1d3681f.

Downstream PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258813
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emersion emersion merged commit ff46858 into swaywm:master Oct 1, 2021
@ekhramtsov ekhramtsov deleted the clang13 branch October 1, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants