free resume_cmd and idle_cmd at swayidle_finish #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resume_cmd and idle_cmd members of swayidle_timeout_cmd were never freed even though the strings are allocated by strdup().
emersion
reviewed
Feb 4, 2021
| @@ -103,6 +103,8 @@ static void swayidle_finish() { | |||
| wl_list_for_each_safe(cmd, tmp, &state.timeout_cmds, link) { | |||
| wl_list_init(&cmd->link); | |||
There was a problem hiding this comment.
Unrelated: this is broken, it overwrites the previous link. The link is already initialized. We should only call wl_list_remove, not wl_list_init.
There was a problem hiding this comment.
Opened #94 to remove that call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resume_cmd and idle_cmd members of swayidle_timeout_cmd were never freed
even though the strings are allocated by strdup().