Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

backend/drm: fix GBM format mismatch #1509

Merged
merged 1 commit into from
Jan 29, 2019
Merged

backend/drm: fix GBM format mismatch #1509

merged 1 commit into from
Jan 29, 2019

Conversation

emersion
Copy link
Member

We create the EGL config with GBM_FORMAT_ARGB8888, but then initialize GBM BOs
with GBM_FORMAT_XRGB8888. This mismatch confuses Mesa.

Instead, we can always use GBM_FORMAT_ARGB8888, and use DRM_FORMAT_XRGB8888
when calling drmModeAddFB2.

Fixes #1438

@emersion
backend/drm: fix GBM format mismatch
ee293fa 
We create the EGL config with GBM_FORMAT_ARGB8888, but then initialize GBM BOs
with GBM_FORMAT_XRGB8888. This mismatch confuses Mesa.

Instead, we can always use GBM_FORMAT_ARGB8888, and use DRM_FORMAT_XRGB8888
when calling drmModeAddFB2.

Fixes swaywm#1438
@emersion emersion mentioned this pull request Jan 29, 2019
Closed
ascent12
ascent12 approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@ascent12 ascent12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll see if this actually fixes anything for people before merging this.

@ddevault ddevault merged commit feb1b9b into swaywm:master Jan 29, 2019
@ddevault
Copy link
Contributor

Thanks! Looks like it did fix the issue for that dude.

@emersion emersion deleted the gbm-fmt-mismatch branch January 29, 2019 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ascent12 ascent12 ascent12 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emersion @ddevault @ascent12