This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
output: re-introduce atomic mode, enabled, scale and transform #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
output-atomic
branch
from
c63a404
to
f54fa8c
Compare
|
Can you point out the changes to this which fix the bug we reverted this for in the first place? |
This comment has been minimized.
This comment has been minimized.
emersion
force-pushed
the
output-atomic
branch
from
f54fa8c
to
3b604e7
Compare
emersion
added a commit
to emersion/sway
that referenced
this pull request
Dec 27, 2019
This reverts commit 724926e and re-applies commit 6e0565e. See also: swaywm/wlroots#1797 (wlroots PR) See also: swaywm#4355 (Original sway PR) See also: swaywm#4434 (Revert sway PR)
emersion
changed the title
emersion
force-pushed
the
output-atomic
branch
from
a19dda7
to
17b4b15
Compare
This reverts commit 01f9038 and re-applies commit ee5f98a. Updates: swaywm#1640 (Atomic output updates issue) See also: swaywm#1762 (Atomic output updates original PR) See also: swaywm#1780 (Issue caused by atomic output updates) See also: swaywm/sway#4419 (Issue caused by atomic output updates) See also: swaywm#1781 (Revert PR)
emersion
force-pushed
the
output-atomic
branch
from
17b4b15
to
69aca27
Compare
emersion
added a commit
to emersion/sway
that referenced
this pull request
Dec 27, 2019
This reverts commit 724926e and re-applies commit 6e0565e. See also: swaywm/wlroots#1797 (wlroots PR) See also: swaywm#4355 (Original sway PR) See also: swaywm#4434 (Revert sway PR)
emersion
added a commit
to emersion/sway
that referenced
this pull request
Dec 28, 2019
This reverts commit 724926e and re-applies commit 6e0565e. Outputs now need to be explicitly enabled when performing a modeset. We need to roll back wlr_output_attach_render when we decide not to render. See also: swaywm/wlroots#1797 (wlroots PR) See also: swaywm#4355 (Original sway PR) See also: swaywm#4434 (Revert sway PR)
This saves one modeset in case the previous mode is different.
In case the pending value is the same as the current value, clear the bit from pending.committed.
emersion
force-pushed
the
output-atomic
branch
from
81a822f
to
6c00331
Compare
emersion
changed the title
|
This is now ready for review. The previous failures were due to To fix this:
I've been testing this pair of PRs on an AMD and Intel GPU, trying things like modesets, hotplugs, DPMS, both manually and automatically triggered by swayidle and kanshi. |
While at it, choose the preferred mode instead of the last one.
|
Thanks! |
ddevault
pushed a commit
to swaywm/sway
that referenced
this pull request
Dec 30, 2019
This reverts commit 724926e and re-applies commit 6e0565e. Outputs now need to be explicitly enabled when performing a modeset. We need to roll back wlr_output_attach_render when we decide not to render. See also: swaywm/wlroots#1797 (wlroots PR) See also: #4355 (Original sway PR) See also: #4434 (Revert sway PR)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 01f9038 and re-applies
commit ee5f98a.
Updates: #1640 (Atomic output updates issue)
See also: #1762 (Atomic output updates original PR)
See also: #1780 (Issue caused by atomic output updates)
See also: swaywm/sway#4419 (Issue caused by atomic output updates)
See also: #1781 (Revert PR)
Sway PR: swaywm/sway#4845
Breaking changes:
wlr_output_commitafterwlr_output_enable,wlr_output_set_mode,wlr_output_set_custom_mode,wlr_output_set_transformorwlr_output_set_scalewlr_output_set_modeno longer implicitly enables the output, compositors need to callwlr_output_enableas wellwlr_output_rollbackafterwlr_output_attach_renderif they decide not to render