This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
Null check surface in xdg_pointer_grab_enter #2180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, opening a popup then moving the cursor somewhere without a surface would crash the compositor.
|
Thanks for the PR, and for looking into this! This fix is also being discussed in #2162, the reason it's not yet merged is there is some discussion as whether this is the best way to go about this or not. |
|
Ah, hadn't seen that one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, opening a popup then moving the cursor somewhere
without a surface would crash the compositor.