This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
Introduce wlr_output_event_commit #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This event contains a `committed` bitfield, which allows callers to know which output fields changed during the commit. This allows users to setup a single atomic commit listener, instead of setting up one listener for each event (mode, scale, transform, and so on). References: swaywm#2098
emersion
force-pushed
the
output-commit-event
branch
from
33f1bea
to
f7aa453
Compare
emersion
changed the title
ddevault
approved these changes
Aug 27, 2020
|
Nice! Do you have a sway patch? |
emersion
added a commit
to emersion/sway
that referenced
this pull request
Aug 27, 2020
Instead of listening to both transform and scale events, we can listen to the commit event and use the new wlr_output_event_commit struct to decide what to do. This de-duplicates some of the work we were doing twice when an output was re-configured. Depends on [1]. [1]: swaywm/wlroots#2315
|
Sway doesn't need to be updated for the breaking change, but here's a patch taking advantage of this PR: swaywm/sway#5649 |
|
Thanks! |
ddevault
pushed a commit
to swaywm/sway
that referenced
this pull request
Aug 27, 2020
Instead of listening to both transform and scale events, we can listen to the commit event and use the new wlr_output_event_commit struct to decide what to do. This de-duplicates some of the work we were doing twice when an output was re-configured. Depends on [1]. [1]: swaywm/wlroots#2315
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output: introduce wlr_output_event_commit
This event contains a
committedbitfield, which allows callers to knowwhich output fields changed during the commit.
This allows users to setup a single atomic commit listener, instead of
setting up one listener for each event (mode, scale, transform, and so
on).
References: #2098
output-power-management-v1: listen to output commit
Breaking change: the
wlr_output.events.commitevent now has a data argument of typestruct wlr_output_event_commit *instead ofstruct wlr_output *