Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

scene: add wlr_scene_attach_output_layout #3160

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

emersion
Copy link
Member

@emersion emersion commented Sep 2, 2021

This is a helper to integrate wlr_scene with wlr_output_layout.

Depends on: #3117


cc @ifreund @kennylevinsen @ammen99

This uses the approach discussed on IRC.

The helper is just dumped in wlr_scene.h, but could be moved elsewhere if desirable.

Copy link
Member

@kennylevinsen kennylevinsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't have a super strong opinion about the location, but maybe there's some value in making the distinction.

@emersion emersion force-pushed the scenegraph-output-layout branch 2 times, most recently from 07fb98c to b5090f5 Compare September 9, 2021 08:17
This will allow more scene-graph extensions to be added without
cluttering wlr_scene.c, for instance for sub-surface handling and
wlr_output_layout integration.
This is a helper to integrate wlr_scene with wlr_output_layout.
@emersion emersion marked this pull request as ready for review September 9, 2021 08:27
@emersion
Copy link
Member Author

emersion commented Sep 9, 2021

I've moved the new helper implementation to a separate source file, but kept the declaration in the wlr_scene.h header for now.

@kennylevinsen kennylevinsen merged commit a181a37 into swaywm:master Sep 9, 2021
@emersion emersion deleted the scenegraph-output-layout branch September 9, 2021 10:10
emersion added a commit to emersion/cage that referenced this pull request Sep 9, 2021
This provides wlr_output_layout integration.

References: swaywm/wlroots#3160
emersion added a commit to emersion/cage that referenced this pull request Sep 22, 2021
This provides wlr_output_layout integration.

References: swaywm/wlroots#3160
emersion added a commit to emersion/cage that referenced this pull request Sep 28, 2021
This provides wlr_output_layout integration.

References: swaywm/wlroots#3160
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants