Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backticks are not being escaped properly in template literals #1488

Closed
djalbat opened this issue Mar 23, 2021 · 1 comment · Fixed by #1516
Closed

Backticks are not being escaped properly in template literals #1488

djalbat opened this issue Mar 23, 2021 · 1 comment · Fixed by #1516
Assignees
Labels
Milestone

Comments

@djalbat
Copy link

djalbat commented Mar 23, 2021

The following code...

`\``

...should be transpiled to:

"`"

However, although the backslash correctly escapes the backtick in the sense that the latter correctly does not close the template literal, the backslash is still present in the transpiled string literal:

"\\`"

The version is 1.2.50.

Many thanks.

@djalbat djalbat added the C-bug label Mar 23, 2021
@kdy1 kdy1 added this to the v1.2.52 milestone Mar 28, 2021
@kdy1 kdy1 self-assigned this Mar 29, 2021
@kdy1 kdy1 mentioned this issue Mar 29, 2021
6 tasks
kdy1 added a commit to kdy1/swc that referenced this issue Mar 29, 2021
kdy1 added a commit to kdy1/swc that referenced this issue Mar 29, 2021
kdy1 added a commit to kdy1/swc that referenced this issue Mar 29, 2021
kdy1 added a commit to kdy1/swc that referenced this issue Mar 29, 2021
kdy1 added a commit that referenced this issue Mar 30, 2021
swc_ecma_ast:
 - Support TypeScript 4.3. (#1517)

swc_ecma_parser:
 - Support new syntaxes from typescript 4.3. (#1517) 

swc_ecma_transforms_compat:
 - Fix '\\`' in template literals. (#1488)
 - `classes`: Fix super calls. (#1490)

swc_ecma_transforms_module:
 - Respect `esModuleInterop` for dynamic imports. (#1480)

swc_ecma_transforms_typescript:
 - `strip`: Remove `declare`-d namespaces. (#1508)
@swc-bot
Copy link
Collaborator

swc-bot commented Oct 25, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

3 participants