Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES codegen should drop last comma in an array literal #5692

Closed
kdy1 opened this issue Aug 31, 2022 · 1 comment · Fixed by #5877
Closed

ES codegen should drop last comma in an array literal #5692

kdy1 opened this issue Aug 31, 2022 · 1 comment · Fixed by #5877
Assignees
@kdy1
Labels
A: ES minifier enhancement
Milestone
v1.3.2

Comments

@kdy1
Copy link
Member

kdy1 commented Aug 31, 2022

Describe the feature

image

swc vs terser

Babel plugin or link to the feature description

No response

Additional context

No response
@kdy1 kdy1 added this to the Planned milestone Aug 31, 2022
@kdy1 kdy1 self-assigned this Aug 31, 2022
@IWANABETHATGUY IWANABETHATGUY mentioned this issue Sep 15, 2022
Merged
kdy1 pushed a commit that referenced this issue Sep 16, 2022
@IWANABETHATGUY
fix(es/codegen): Drop the last comma in an array literal (#5877)
7d6d04b 
**Description:**

Drop the last comma in an array literal.

**Related issue:**

 - Closes #5692.
@kdy1 kdy1 modified the milestones: Planned, v1.3.2 Sep 19, 2022
@swc-bot
Copy link
Collaborator

swc-bot commented Oct 19, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdy1 kdy1

Labels
A: ES minifier enhancement
Milestone
v1.3.2
Development

Successfully merging a pull request may close this issue.

fix(swc_ecma_codegen): should drop last comma in an array literal IWANABETHATGUY/swc
2 participants
@kdy1 @swc-bot